Review Request 1158: Data migration for adding collectors for existing users. Adding collector entries during confirmation of indexers.

[Witold Karpeta]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

Review request for GCD Tech Group. By Witold Karpeta. Description I added data migration for creating collectors and collections for existing users. I also added creating collector with default collections during confirmation of a new indexer (and not during creating of a new indexer to avoid creating entries that could never be used). This two things should probably allow a first production deployment since after that all confirmed users should always have collectors and collections. Testing I run the new migration and checked that it worked well. I tried to register new user locally and check that collector and collections were correctly created. Diffs apps/gcd/views/accounts.py (1c0e3743fabe78dc9dffdd431607d13ded6c70bc) apps/mycomics/migrations/0002_creating_collectors.py (PRE-CREATION) apps/mycomics/models.py (88ff917f6759c0bea4f2b19fcf02153eaef280a0) settings.py (b774fae60747357b6aaac2ad146873d094021eea) View Diff

[Jochen G.]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

What do you mean by "first production deployment" ? There are so far no template changes to actually use this ?

- Jochen

On May 4th, 2013, 11:06 p.m. UTC, Witold Karpeta wrote:

Review request for GCD Tech Group. By Witold Karpeta.

Updated May 4, 2013, 11:06 p.m.

[Witold Karpeta]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

On May 6th, 2013, 5:56 p.m. CEST, Jochen G. wrote:

What do you mean by "first production deployment" ? There are so far no template changes to actually use this ?

Exactly. And it could be deployed just to have models ready and consistent. There would be just default collector data until deploying any page templates but it wouldn't hurt also.
But I'm not telling you to do it, just that it would be possible to commit this to devel and then to master. And it's just fine for me to keep working in mycomics branch.

- Witold

On May 5th, 2013, 1:06 a.m. CEST, Witold Karpeta wrote:

Review request for GCD Tech Group. By Witold Karpeta.

Updated May 5, 2013, 1:06 a.m.

[Jochen G.]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

apps/mycomics/migrations/0002_creating_collectors.py (Diff revision 2)
		10	"Write your forwards methods here."

One " ? Not """"

apps/mycomics/migrations/0002_creating_collectors.py (Diff revision 2)
		11	#from django.contrib.auth.models import User

import not needed ? Instead of commenting out we can remove that line.

- Jochen

On May 4th, 2013, 11:06 p.m. UTC, Witold Karpeta wrote:

Review request for GCD Tech Group. By Witold Karpeta.

Updated May 4, 2013, 11:06 p.m. Description

[Witold Karpeta]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

On May 9th, 2013, 11:38 a.m. CEST, Jochen G. wrote:

apps/mycomics/migrations/0002_creating_collectors.py (Diff revision 2)
		10	"Write your forwards methods here."

One " ? Not """"

It's a comment generated automatically by south. I'll remove it.

On May 9th, 2013, 11:38 a.m. CEST, Jochen G. wrote:

apps/mycomics/migrations/0002_creating_collectors.py (Diff revision 2)
		11	#from django.contrib.auth.models import User

import not needed ? Instead of commenting out we can remove that line.

Yep. Of course, I just missed this one. Will be gone.

- Witold

On May 5th, 2013, 1:06 a.m. CEST, Witold Karpeta wrote:

Review request for GCD Tech Group. By Witold Karpeta.

Updated May 5, 2013, 1:06 a.m. Description

[Witold Karpeta]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

Review request for GCD Tech Group. By Witold Karpeta.

Updated May 11, 2013, 12:33 a.m. Changes I removed unnecessary comments.

Description I added data migration for creating collectors and collections for existing users. I also added creating collector with default collections during confirmation of a new indexer (and not during creating of a new indexer to avoid creating entries that could never be used). This two things should probably allow a first production deployment since after that all confirmed users should always have collectors and collections. Testing I run the new migration and checked that it worked well. I tried to register new user locally and check that collector and collections were correctly created.

Diffs (updated)

[Jochen G.]

This is an automatically generated e-mail. To reply, visit: http://reviews.comics.org/r/1158/

Ship it!

Ship It!

- Jochen

On May 10th, 2013, 10:33 p.m. UTC, Witold Karpeta wrote:

Review request for GCD Tech Group. By Witold Karpeta.

Updated May 10, 2013, 10:33 p.m.

Description I added data migration for creating collectors and collections for existing users. I also added creating collector with default collections during confirmation of a new indexer (and not during creating of a new indexer to avoid creating entries that could never be used). This two things should probably allow a first production deployment since after that all confirmed users should always have collectors and collections. Testing I run the new migration and checked that it worked well. I tried to register new user locally and check that collector and collections were correctly created. Diffs