[GrandComicsDatabase/gcd-django] When migrating a credit results in multiple hits, provide a UI to pick which one of the hits is correct (Issue #546)

2 views
Skip to first unread message

Richard Thomson

unread,
Sep 29, 2022, 5:30:45 PMSep 29
to GrandComicsDatabase/gcd-django, Subscribed

Currently what happens is that the credit is unmigrated and you manually copy/paste the creators name into the box and pick from one of the database hits via the dropdown.

Since we already did the database search and found the multiple hits when we attempted to migrate the credit, provide some sort of UI that lists the creators that were found to let you fill out the field with a one-click step using front-end javascript and no additional server round trip.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546@github.com>

Richard Thomson

unread,
Sep 29, 2022, 5:31:37 PMSep 29
to GrandComicsDatabase/gcd-django, Subscribed

... the same sort of UI could be provided for features that had multiple hits, e.g. Captain Atom.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1262838709@github.com>

JochenGCD

unread,
Sep 29, 2022, 11:06:43 PMSep 29
to GrandComicsDatabase/gcd-django, Subscribed

Would be a new database search (although maybe a cached query by the db-server). There is no practical path to further propagate intermediate results from the migration back to the UI. Only by storing these "somewhere" intermediately, would likely would be make the flow more state-dependent and brittle.

Nice idea, but I think too little gain for the needed work.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1263049584@github.com>

Richard Thomson

unread,
Sep 30, 2022, 12:28:55 PMSep 30
to GrandComicsDatabase/gcd-django, Subscribed

Can you point me to where the migration algorithm is in the code? I'll take a look and see if there's some potential "low hanging fruit".


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1263779750@github.com>

JochenGCD

unread,
Sep 30, 2022, 2:45:09 PMSep 30
to GrandComicsDatabase/gcd-django, Subscribed

The migration is on apps/oi/models.py for the issue and story revision model.

To pass the info forward one would also need to change the routines (and forms ?) for bringing the editing page. Which would then become state dependent, which we try to avoid ?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1263902613@github.com>

Richard Thomson

unread,
Oct 1, 2022, 7:54:55 PMOct 1
to GrandComicsDatabase/gcd-django, Subscribed

Can you elaborate on what you mean by "state dependent"?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1264510716@github.com>

JochenGCD

unread,
Oct 2, 2022, 6:24:51 AMOct 2
to GrandComicsDatabase/gcd-django, Subscribed

The front end editing would depend on how one gets there. There would be a difference between reaching the editing page by clicking edit vs. after a migration click. The code for making the form and page would know to know this state.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1264606176@github.com>

Richard Thomson

unread,
Oct 3, 2022, 11:46:10 PMOct 3
to GrandComicsDatabase/gcd-django, Subscribed

I'm actually thinking that the entire thing can be provided in the front-end... there is already some sort of ajax discussion going on between the form and the back end for the dynamic search when you are typing in the name of a creator. It shouldn't matter whether you get there by 'edit' or by 'migrate'.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1266357664@github.com>

JochenGCD

unread,
Oct 4, 2022, 3:07:23 AMOct 4
to GrandComicsDatabase/gcd-django, Subscribed

Sure. But then there is the question if this should be there for every unmigrated credit.We don't force indexers to migrate, so it should be only there on request. In other words, for which text credits should this show ? In that view, it would make sense to show this only after a migrate ? Or do provide a button for an 'in page' migration for each text credit ?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1266501446@github.com>

Richard Thomson

unread,
Oct 5, 2022, 4:38:08 PMOct 5
to GrandComicsDatabase/gcd-django, Subscribed

My thinking was that it would appear below the credits text box as openable triangle (that is initially closed) with some sort of text like "pick one from a list". Opening the triangle would result in choices appearing below the text credit box and picking one would result in the equivalent of "add another" being clicked and the appropriate fields being filled out.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1268947916@github.com>

JochenGCD

unread,
Oct 6, 2022, 2:58:37 AMOct 6
to GrandComicsDatabase/gcd-django, Subscribed

Sure. So you mean to have this box under every unmigrated credit ? Maybe with several in case there is more than one credit per type ?
Autocomplete mostly would have results for untouched issues, so most of the time these would be there ?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1269442765@github.com>

Richard Thomson

unread,
Oct 7, 2022, 10:13:19 PMOct 7
to GrandComicsDatabase/gcd-django, Subscribed

My thinking was that there would be a single (initially collapsed) triangle altering you to the availability of autocomplete "pick and migrate" options and that expanding it would show you all the relevant possibilities for that credit.

You're right that if there are a bunch of creators listed for a single credit, then it could balloon into a large list of options to choose from -- one pickable result for each autocomplete response provided for each creator. So I think it's best to have this hidden by default.

There's also the situation that we may not like the script running all these autocomplete queries every time you edit an issue and the search could be delayed until you expand the triangle manually.

So far, everything I've described is achievable only with front-end JavaScript code.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1272197970@github.com>

Jochen Garcke

unread,
Oct 8, 2022, 4:39:36 AMOct 8
to GrandComicsDatabase/gcd-django, Subscribed

Yes, checking if if there are autocompletes shouldn't be done for each story editing page, would be quite a bit of unneeded queries.

But then, if it is up to the user clicking on the triangle manually, than there is overall not so much difference to clicking the migrate button for the whole issue ? (as in, for the text credits that are unmigrated since nothing was done so far, on them, not for the unmigrated due to multiple hits)

Maybe not that straightforward ? Thinking this through gives a bit of side constraints / effects ?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1272267642@github.com>

JochenGCD

unread,
Oct 8, 2022, 4:40:23 AMOct 8
to GrandComicsDatabase/gcd-django, Subscribed

Yes, checking if if there are autocompletes shouldn't be done for each story editing page, would be quite a bit of unneeded queries.

But then, if it is up to the user clicking on the triangle manually, than there is overall not so much difference to clicking the migrate button for the whole issue ? (as in, for the text credits that are unmigrated since nothing was done so far, on them, not for the unmigrated due to multiple hits)

Maybe not that straightforward ? Thinking this through gives a bit of side constraints / effects ?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1272267787@github.com>

Richard Thomson

unread,
Oct 8, 2022, 8:59:14 PMOct 8
to GrandComicsDatabase/gcd-django, Subscribed

The idea is to help automate the process that isn't handled by the existing migrate button. Maybe we can do something so that this is only rendered into the form on the result of a 'migrate credits' submission and not on an ordinary edit submission.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/546/1272424399@github.com>

Reply all
Reply to author
Forward
0 new messages