[GrandComicsDatabase/gcd-django] Fix issue with markdown and gcd_link* not working inside collapsible details sections in markdown (PR #698)
Adam Knights
Allows a user to add markdown="1" so that collapsible markdown can have markdown within it, including our gcd_link_* syntax
<details markdown="1">
<summary>Some section name</summary>
- Item 1 [gcd_link_issue](123)
- Item 2
- Item 3
</details>
Will mean that https://beta.comics.org/character/6122/ on beta will then start rendering nicely. Local testing equivalent:
image.png (view on web)You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/698
Commit Summary
- b4478f1 Fix issue with markdown and gcd_link* not working inside collapsable details sections
File Changes
(1 file)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/698.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/698.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
gemini-code-assist[bot] left a comment (GrandComicsDatabase/gcd-django#698)Summary of Changes
Hello @adam-knights, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves an issue where markdown content, specifically custom gcd_link_* syntax, was not correctly processed inside HTML <details> sections. By incorporating the md_in_html Markdown extension, the system now properly renders and displays markdown within these collapsible elements, enhancing content presentation and user experience.
Highlights
- Markdown in HTML Details: Enabled markdown rendering, including custom
gcd_link_*syntax, within HTML<details>tags by integrating themd_in_htmlextension into the markdown processor.
- apps/gcd/templatetags/credits.py
- Added the
md_in_htmlextension to the list of Markdown extensions used by themarkdownfilter.
- Added the
- No human activity has been recorded on this pull request yet.
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
@gemini-code-assist[bot] commented on this pull request.
Code Review
This pull request introduces a fix for rendering markdown content within collapsible <details> sections by enabling the md_in_html extension in the markdown processor. The change is concise, directly addresses the issue, and allows for richer content formatting in collapsible sections as demonstrated in the pull request description. The implementation is correct and follows the standard way of enabling Python-Markdown extensions. This is a good improvement.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.