[GrandComicsDatabase/gcd-django] Add the ability to add creator object editors on bulk issue add (PR #694)
Adam Knights
This PR add the ability to use creator objects for editors when adding multiple issues in one go. I believe this fills the last gap of screens where using creator objects was not available.
It also fixes a small bug I noticed in testing, where currently age rating and no age rating were on the form, but were not persisted.
Testing:
Tested locally with a variety of editors, including credit description. Tested submit, approve and view. Tested validation when no credit description. Example testing screenshots below.
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/694
Commit Summary
- c84ca86 Implement creator object editors on bulk issue add + fix age rating bug
File Changes
(3 files)
- M apps/oi/forms/issue.py (24)
- M apps/oi/views.py (39)
- M templates/oi/edit/add_frame.html (4)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/694.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/694.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#694)Did you run flake8 on it ? Seems lines are longer than 80 chars ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Adam Knights
@adam-knights pushed 1 commit.
- 1c5d9d0 Fix formatting
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Adam Knights
adam-knights left a comment (GrandComicsDatabase/gcd-django#694)I did not - I'm still getting used to python, but it is growing on me, so flake8 was new. I've now used it here, and will for future contributions.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
@jochengcd approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.