[GrandComicsDatabase/gcd-django] concurrent approve and discard (#376)
jochengcd
While double approvals should not happen any more, there can be a race conflict between the approver approving a change, and the indexer discarding it. This can result in a bad db-state for add in the rare case when these two operations are happening at the same time (if there is a lag, the check for the state will prevent this).
Maybe we can also use a lock for the changeset to prevent this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
jhunterjActual
jhunterjActual left a comment (GrandComicsDatabase/gcd-django#376)Appears to have been fixed in 2020 with c8f2135 . If wanted, we could add regression tests to the suite to continue to confirm the behavior with new work.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.