[GrandComicsDatabase/gcd-django] Deprecate universe field direct on characters and groups (PR #704)
Adam Knights
This implements the first stage of the vote (https://www.comics.org/voting/ballot/553/) to deprecate universe being directly set on characters and groups.
Testing:
New characters / groups no longer show the field:
image.png (view on web) image.png (view on web)Adding a new character / groups continues to work.
Editing characters / groups with no universe, don't show it
image.png (view on web) image.png (view on web)If universe already set, view marks it as deprecated
image.png (view on web) image.png (view on web)When editing with universe set, shows explaination text
image.png (view on web) image.png (view on web)--
Happy to tweak anything, just let me know :)
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/704
Commit Summary
- dbc36f1 Deprecate universe field direct on characters and groups
File Changes
(4 files)
- M apps/oi/forms/character.py (18)
- M apps/oi/models.py (8)
- M templates/gcd/details/tw_character.html (2)
- M templates/gcd/details/tw_group.html (2)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/704.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/704.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
@gemini-code-assist[bot] commented on this pull request.
Code Review
This pull request deprecates the 'universe' field for characters and groups. Changes include adding deprecation help text to forms, removing the field from character forms when no universe is set, and updating templates to display a 'deprecated' label. Additionally, a helper method was added to the models to identify 'universe' as a deprecated field. I have no feedback to provide as there were no review comments to evaluate.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.