[GrandComicsDatabase/gcd-django] api_v2: Add option to sign cover image URLs with HMAC token (PR #778)
Alexandros Diamantidis
Description
Our production site is protected by Cloudflare. The API v2 issue endpoint returns the cover scan URL, but when API users try to access it, they might need to pass Cloudflare's challenge.
By setting URL_SIGN_SECRET_KEY in settings, cover URLs returned by the API are signed with a HMAC token which allows direct access to the URL, provided the setup at the following page is implemented:
https://developers.cloudflare.com/waf/custom-rules/use-cases/configure-token-authentication/
Testing
Verified that API responses contain the token. No testing done in Cloudflare yet to check that it actually works.
AI usage
Did you use AI (e.g. Claude, ChatGPT, Copilot, etc.) to help produce this PR?
- Yes
- No
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/778
Commit Summary
- 364292e api_v2: Add option to sign cover image URLs with HMAC token
File Changes
(1 file)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/778.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/778.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Alexandros Diamantidis
@adia pushed 1 commit.
- 1f98dd1 api_v2: Add option to sign cover image URLs with HMAC token
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Alexandros Diamantidis
@adia pushed 1 commit.
- be3e829 api_v2: Add option to sign cover image URLs with HMAC token
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#778)You have access to beta and cloudflare for setting this up ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Alexandros Diamantidis
adia left a comment (GrandComicsDatabase/gcd-django#778)Thanks, I do! I see the change is already on beta, so I'll try applying the rule on Cloudflare to see if it'll work.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.