[GrandComicsDatabase/gcd-django] Migration of editing credits doesn't seem to be as smart as migrating story credits (Issue #543)
Richard Thomson
For instance, if the original editing field is:
Alf Wallace [as Alf]; Bob Bartholomew [as Bart]
Then the migrate button doesn't do anything, whereas I would have expected it to migrate the name and put the "Alf" in the "Credited as" box and "Bart" in the "Credited as" box, like it does for story credits.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Richard Thomson
So... it does the right thing with this in arts credits?
Alf Wallace [as Alf] (credited)
I tried adding "(credited)" to the editor credits line before clicking migrate and it didn't pick that up.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
Richard Thomson
If someone can point me to the code where the edit credits are migrated, I'll poke around and see what I can find out.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
JochenGCD
this
Alf Wallace [as Alf]; Bob Bartholomew [as Bart]
didn't migrate since Alf and Bart exist twice in the database. (the other Alf can be deleted though)
This example doesn't migrate for story credits either due to that.
Generally the 'as' does work for issue edits.
I deleted the other Alf, Alf Wallace [as Alf] now migrates for issue editing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
JochenGCD
Closed #543 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.