[GrandComicsDatabase/gcd-django] fix: update Dockerfile.dev and translation files (PR #761)
Simone Nardi
Summary of Changes
-
Docker Development Environment (
Dockerfile.dev)- Added the
gettextpackage to the development Docker image. - This provides the
msgfmtutility required by Django'scompilemessagescommand to compile.potranslation files into.mofiles.
- Added the
-
Localization Fixes
-
Italian (
locale/it/LC_MESSAGES/django.po)- Fixed syntax and formatting issues that prevented the translation file from compiling correctly.
- Updated some Italian translations.
-
Portuguese (
locale/pt/LC_MESSAGES/django.po)- Fixed syntax and formatting issues that prevented the translation file from compiling correctly.
-
Testing
- Rebuilt the development Docker environment with the updated
Dockerfile.dev. - Successfully ran
python manage.py compilemessages. - Verified that the Italian and Portuguese translations are correctly loaded and displayed by the website.
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/761
Commit Summary
- 581c6b0 fix: update Dockerfile.dev and translation files
File Changes
(3 files)
- M Dockerfile.dev (1)
- M locale/it/LC_MESSAGES/django.po (51)
- M locale/pt/LC_MESSAGES/django.po (4)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/761.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/761.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
@gemini-code-assist[bot] commented on this pull request.
Code Review
This pull request adds the gettext package to the development Dockerfile and updates several Italian and Portuguese translation strings in the Django PO files. The feedback suggests reverting the translation of 'Documentation Wiki' back to 'Wiki della documentazione' to maintain natural Italian phrasing, and keeping the established comic-specific term 'testata' instead of using the English loanword 'feature' for 'Feature Logo Scan' translations.
In locale/it/LC_MESSAGES/django.po:
> @@ -433,11 +434,11 @@ msgstr "Come contribuire" #: templates/gcd/bits/front_page_menu.html:13 msgid "Documentation Wiki" -msgstr "Wiki della documentazione" +msgstr "Documentazione Wiki"
In Italian, 'Wiki della documentazione' is grammatically correct and natural because the noun-adjective/noun-noun modifier order is reversed compared to English. 'Documentazione Wiki' sounds like a literal word-for-word translation and is less natural. It is recommended to revert this change to keep the translation natural.
msgstr "Wiki della documentazione"
In locale/it/LC_MESSAGES/django.po:
> #: templates/gcd/details/feature_logo.html:63 #: templates/gcd/details/tw_feature_logo.html:68 msgid "Replace Feature Logo Scan" -msgstr "Sostituisci scansione del logo della testata" +msgstr "Sostituisci la scansione del logo della feature"
The term 'testata' is a well-established and natural Italian comic-specific term for 'feature' (referring to a comic title or series). Replacing it with the English loanword 'feature' makes the translation sound less natural and more like technical jargon. It is recommended to keep 'testata' or use a more natural Italian equivalent like 'serie' or 'personaggio'.
msgstr "Sostituisci la scansione del logo della testata"
In locale/it/LC_MESSAGES/django.po:
> #: templates/gcd/details/feature_logo.html:67 #: templates/gcd/details/tw_feature_logo.html:72 msgid "Delete Feature Logo Scan" -msgstr "Elimina scansione del logo della testata" +msgstr "Elimina la scansione del logo della feature"
The term 'testata' is a well-established and natural Italian comic-specific term for 'feature' (referring to a comic title or series). Replacing it with the English loanword 'feature' makes the translation sound less natural and more like technical jargon. It is recommended to keep 'testata' or use a more natural Italian equivalent like 'serie' or 'personaggio'.
msgstr "Elimina la scansione del logo della testata"
In locale/it/LC_MESSAGES/django.po:
> #: templates/gcd/details/feature_logo.html:75 #: templates/gcd/details/tw_feature_logo.html:80 msgid "Add Feature Logo Scan" -msgstr "Aggiungi scansione del logo della testata" +msgstr "Aggiungi la scansione del logo della feature"
The term 'testata' is a well-established and natural Italian comic-specific term for 'feature' (referring to a comic title or series). Replacing it with the English loanword 'feature' makes the translation sound less natural and more like technical jargon. It is recommended to keep 'testata' or use a more natural Italian equivalent like 'serie' or 'personaggio'.
msgstr "Aggiungi la scansione del logo della testata"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Simone Nardi
@ProfNardi pushed 1 commit.
- de5d25c fix: address code review comments on Italian translations
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
gemini-code-assist[bot] left a comment (GrandComicsDatabase/gcd-django#761)Thank you for the clarification, Don. I understand that 'feature' is used as a specific technical term within the GCD project. Given that context, keeping 'feature' is perfectly appropriate to maintain technical consistency. I will keep this in mind for future reviews.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
JochenGCD
@jochengcd commented on this pull request.
Please reply (or act) to the comment from Don
In locale/it/LC_MESSAGES/django.po:
> # #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:46+0000\n" -"PO-Revision-Date: 2021-02-22 23:10+0000\n" -"Last-Translator: b'Donald Dale Milne <dond...@att.net>'\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
shouldn't this be a valid date ?
In locale/pt/LC_MESSAGES/django.po:
> @@ -7,14 +8,13 @@ msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:33+0000\n" -"PO-Revision-Date: 2023-08-18 16:55+0000\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
see above
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
Simone Nardi
@ProfNardi commented on this pull request.
In locale/it/LC_MESSAGES/django.po:
> # #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:46+0000\n" -"PO-Revision-Date: 2021-02-22 23:10+0000\n" -"Last-Translator: b'Donald Dale Milne <dond...@att.net>'\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
The line:
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
is exactly what causes the conflict. It was the only substantial difference compared to the other working languages and, at the same time, the only element they had in common with Portuguese.
As soon as I changed it, the problem disappeared and everything started working correctly.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
Simone Nardi
@ProfNardi commented on this pull request.
In locale/pt/LC_MESSAGES/django.po:
> @@ -7,14 +8,13 @@ msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:33+0000\n" -"PO-Revision-Date: 2023-08-18 16:55+0000\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
I’d like to reply to Don’s comment, but I can’t do so directly from here (I’d have to use email). So I’ll take the opportunity to mention it here: another PR is already ready that improves and effectively supersedes the current one.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
JochenGCD
@jochengcd commented on this pull request.
In locale/it/LC_MESSAGES/django.po:
> # #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:46+0000\n" -"PO-Revision-Date: 2021-02-22 23:10+0000\n" -"Last-Translator: b'Donald Dale Milne <dond...@att.net>'\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
compilemessages works fine for me ? What was the error message ? These are the dates of the last revision, which for IT/PT was existing since it was entered via the rosetta-gui.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
JochenGCD
@jochengcd commented on this pull request.
In locale/pt/LC_MESSAGES/django.po:
> @@ -7,14 +8,13 @@ msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:33+0000\n" -"PO-Revision-Date: 2023-08-18 16:55+0000\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
If there is another PR that supersedes the current one, why is this one still active ? Or at least noted as being superseded ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
Simone Nardi
@ProfNardi commented on this pull request.
In locale/pt/LC_MESSAGES/django.po:
> @@ -7,14 +8,13 @@ msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2026-01-31 15:33+0000\n" -"PO-Revision-Date: 2023-08-18 16:55+0000\n" +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
This PR is superseded by #765.
The changes have been incorporated into the newer PR, which should be reviewed and merged instead.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.
Simone Nardi
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you commented.