[GrandComicsDatabase/gcd-django] Repair test suite (PR #724)
Josef Andersson
Updates the remaining tests for the brand_emblem and indicia printer
renames, and fixes a has_calls typo that silently skipped assertions.
Suite is green afterwards: 408 passed
builds on PR
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/724
Commit Summary
- f3332e6 fix brand emblem regressions from the m2m migration
- dc76da6 update issue revision tests for the brand emblem changes
- 26a897e repair the test suite after the brand emblem and field renames
File Changes
(12 files)
- M apps/gcd/tests/test_issue.py (6)
- M apps/gcd/tests/test_publisher.py (5)
- M apps/gcd/tests/test_series.py (21)
- M apps/oi/models.py (24)
- M apps/oi/tests/conftest.py (8)
- M apps/oi/tests/db/test_issue_revision.py (118)
- M apps/oi/tests/db/test_printer_revision.py (7)
- M apps/oi/tests/test_issue_revision.py (22)
- M apps/oi/tests/test_reprint_revision.py (16)
- M apps/oi/tests/test_revision.py (2)
- M apps/oi/tests/test_series_revision.py (6)
- M apps/stats/tests/test_countstats.py (18)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/724.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/724.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Josef Andersson
@janderssonse pushed 2 commits.
- 9273b5d update issue revision tests for the brand emblem changes
- 4b0a9ee repair the test suite after the brand emblem renames
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Josef Andersson
@janderssonse pushed 3 commits.
- 0a57c02 fix: brand emblem regressions from the m2m migration
- bfd2a59 test: update issue revision tests for the brand emblem changes
- ed635b8 test: repair the suite after the brand emblem renames
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#724)/gemini review
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
@gemini-code-assist[bot] commented on this pull request.
Code Review
This pull request primarily refactors the codebase to transition the brand field on issues to brand_emblem (supporting many-to-many relationships), updating the corresponding models, revision logic, and test suites. Additionally, it updates the filtering of active indexed issues from excluding skeleton issues to filtering by a minimum data threshold, refactors stats tracking for brand groups, and refines various unit tests to improve mocking and assertion accuracy. I have no feedback to provide as there are no review comments to evaluate.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.