[GrandComicsDatabase/gcd-django] When an error is detected in editing, the first tab with an error should be selected (Issue #530)

2 views
Skip to first unread message

Richard Thomson

unread,
Aug 10, 2022, 12:25:19 PMAug 10
to GrandComicsDatabase/gcd-django, Subscribed

If I make a mistake on the Characters tab, then "Save and Return to Changeset" should have the characters tab displayed showing the error when the page is rendered after submission.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/530@github.com>

JochenGCD

unread,
Aug 20, 2022, 8:35:54 AMAug 20
to GrandComicsDatabase/gcd-django, Subscribed

This would also concern the Creator Credits tab.

Unfortunately not straightforward. I think one would need to collect and process the errors when processing the form and check on which tab the error is, or which is the first tab with errors. This info needs to be given to the template, where it needs to be processed. Not sure if we can (or want) a redirect with #creator-credits added to the URL, or with javascript ?

Another improvement might be to highlight tabs with errors, i.e. some errors on creators or characters don't give any info on the first tab,


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/530/1221307089@github.com>

JochenGCD

unread,
Aug 21, 2022, 12:10:15 PMAug 21
to GrandComicsDatabase/gcd-django, Subscribed

Processing on the backend was easier then thought. We now show if there are errors on the other tabs.

That info could maybe processed by javascript to eventually directly go to the other tabs. Someone else would need to do this.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/530/1221575119@github.com>

Richard Thomson

unread,
Aug 24, 2022, 1:56:39 PMAug 24
to GrandComicsDatabase/gcd-django, Subscribed

Yes, I see that the experience is improved now, thanks!

Certainly a little javascript hook on document load could identify tabs with errors and either give them an appropriate CSS class, or simply select the first tab with errors. I have experience with JavaScript and could help out here if desired.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/530/1226053766@github.com>

JochenGCD

unread,
Aug 25, 2022, 10:29:16 PMAug 25
to GrandComicsDatabase/gcd-django, Subscribed

As I wrote, someone else would need to do this, so anyone willing is welcomed.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/530/1227974794@github.com>

Reply all
Reply to author
Forward
0 new messages