[GrandComicsDatabase/gcd-django] Normalize capitalization of editor titles when migrating editing credits (Issue #544)

3 views
Skip to first unread message

Richard Thomson

unread,
Sep 29, 2022, 4:45:24 PM9/29/22
to GrandComicsDatabase/gcd-django, Subscribed

A reviewer left the comment that when attributing editor roles to a credit, the role is written without capitalization, e.g. "editor" not "Editor". When migrating editing credits, the software should fix the capitalization for me.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544@github.com>

JochenGCD

unread,
Sep 29, 2022, 5:01:44 PM9/29/22
to GrandComicsDatabase/gcd-django, Subscribed

Not really feasible. The capitalization depends on the language. And since indexes might be in a foreign language, we cannot go by the language of the comic.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1262811376@github.com>

Richard Thomson

unread,
Sep 29, 2022, 5:28:06 PM9/29/22
to GrandComicsDatabase/gcd-django, Subscribed

Surely we can recognize the common case for English?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1262836304@github.com>

JochenGCD

unread,
Sep 29, 2022, 5:30:09 PM9/29/22
to GrandComicsDatabase/gcd-django, Subscribed

But we don't know when to use English ?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1262837860@github.com>

Richard Thomson

unread,
Sep 30, 2022, 12:30:27 PM9/30/22
to GrandComicsDatabase/gcd-django, Subscribed

If we don't know an issue is English, then how does the feature migration query work in the dropdown to recognize foreign language features? To me that implies that something knows this issue is in a particular language when I'm editing it.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1263781180@github.com>

JochenGCD

unread,
Sep 30, 2022, 2:46:26 PM9/30/22
to GrandComicsDatabase/gcd-django, Subscribed

We know the language of the series, but we don't know in which language the edits are performed.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1263903692@github.com>

JochenGCD

unread,
Sep 30, 2022, 2:58:25 PM9/30/22
to GrandComicsDatabase/gcd-django, Subscribed

What would be a way is to have a button on the issue editing page to lowercase the entry on indexer request.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1263914204@github.com>

Richard Thomson

unread,
Oct 1, 2022, 7:53:51 PM10/1/22
to GrandComicsDatabase/gcd-django, Subscribed

What would be a way is to have a button on the issue editing page to lowercase the entry on indexer request.

Yeah, this could easily be done on the front-end with some javascript. I'm going to be setting up a development environment soon and this would be an easy change to the template.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/544/1264510593@github.com>

Reply all
Reply to author
Forward
0 new messages