[GrandComicsDatabase/gcd-django] wrong cover is needed search results in case of deleted covers (#499)

3 views
Skip to first unread message

jochengcd

unread,
Sep 21, 2021, 4:32:17 PMSep 21
to GrandComicsDatabase/gcd-django, Subscribed

Issues where covers were deleted and later new ones were uploaded appear in the cover is needed search.

here the second Q-needs to be changed, but ad-hoc don't see how
if data['cover_needed']:
q_objs.append(Q({'%scover__isnull' % prefix: True}) |
~Q(
{'%scover__deleted' % prefix: False}) |
Q(**{'%scover__marked' % prefix: True}))

example where the first three show up wrongly
GCD :: Issue :: The Batman & Scooby-Doo Mysteries #6 (comics.org)
GCD :: Issue :: Batman: Urban Legends #7 (comics.org)
GCD :: Issue :: Batman: Urban Legends #7 [Hicham Habchi Samurai Batman Variant Cover] (comics.org)

https://www.comics.org/search/advanced/process/?target=issue&method=icontains&logic=False&keywords=&title=&feature=&job_number=&pages=&pages_uncertain=&script=&pencils=&inks=&colors=&letters=&story_editing=&first_line=&characters=&synopsis=&reprint_notes=&story_reprinted=&notes=&issues=&volume=&issue_title=&variant_name=&is_variant=&issue_date=&indicia_frequency=&price=&issue_pages=&issue_pages_uncertain=&issue_editing=&isbn=&barcode=&rating=&issue_notes=&issue_reprinted=&cover_needed=on&is_indexed=&in_selected_collection=on&order1=series&order2=date&order3=&start_date=09%2F14%2F21&end_date=09%2F14%2F21&use_on_sale_date=on&updated_since=&pub_name=DC&pub_notes=&brand_group=&brand_emblem=&brand_notes=&indicia_publisher=&is_surrogate=&ind_pub_notes=&series=&series_year_began=&series_notes=&publication_type=2&tracking_notes=&issue_count=&is_comics=&color=&dimensions=&paper_stock=&binding=&publishing_format=


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Reply all
Reply to author
Forward
0 new messages