[GrandComicsDatabase/gcd-django] Fix bad link on issue counts in universe characters page (PR #697)
Adam Knights
In #696 we moved to an expanded overview origin universe page, rather than going straight to issues, fix gap where the universe -> characters page issue counts should now re-use the same url.
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/697
Commit Summary
- c49eda9 Fix bad link on issue counts in universe characters page
File Changes
(1 file)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/697.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/697.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
gemini-code-assist[bot] left a comment (GrandComicsDatabase/gcd-django#697)Summary of Changes
Hello @adam-knights, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a broken link on the universe characters page. Following a recent update that introduced an expanded overview for the origin universe, the link responsible for displaying issue counts was pointing to an outdated route. This change updates the URL to the correct, newly established route, ensuring proper navigation and user experience.
Highlights
- URL Route Correction: Updated the URL route name for character issue counts on the universe characters page from 'character_issues_per_universe' to 'character_origin_universe_issues'. This change ensures consistency with the expanded origin universe page introduced in a previous pull request.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Changelog- apps/gcd/models/character.py
- Modified the
render_issue_countmethod to use the updated URL routecharacter_origin_universe_issuesinstead ofcharacter_issues_per_universe.
- Modified the
- No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
@gemini-code-assist[bot] commented on this pull request.
Code Review
This pull request addresses a broken link on the issue counts within the universe characters page. The change correctly updates the urlresolvers.reverse call to use the 'character_origin_universe_issues' URL name instead of the outdated 'character_issues_per_universe'. This is a necessary fix to align with the expanded overview for universe origins. The change is correct and well-contained.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.