Issue 170657538: Specifying LIBGAV1_THREADPOOL_USE_STD_MUTEX flag doesn't remove dependency on Abseil
32 views
Skip to first unread message
buganize...@google.com
Oct 13, 2020, 1:07:30 AM10/13/20
to gav1-deve...@googlegroups.com
Replying to this email means your email address will be shared with the team that works on this product.
https://issuetracker.google.com/issues/170657538
Reference Info: 170657538 Specifying LIBGAV1_THREADPOOL_USE_STD_MUTEX flag doesn't remove dependency on Abseil
status: New
reporter: vi...@gmail.com
cc: ga...@googlegroups.com, vi...@gmail.com
type: Bug
priority: P4
severity: S2
retention: Component default
vi...@gmail.com added comment #1:
Branch: master
Tag: v0.16.0
Specifying the mentioned flag doesn't removed dependency in CMake. If Abseil is not required any more, why CMake fails if there is no Abseil sources?
Regards,
Victor
Generated by Google IssueTracker notification system
You're receiving this email because you are subscribed to updates on Google IssueTracker issue 170657538.
Unsubscribe from this issue.
buganize...@google.com
Oct 13, 2020, 3:15:28 PM10/13/20
to gav1-deve...@googlegroups.com
Replying to this email means your email address will be shared with the team that works on this product.
https://issuetracker.google.com/issues/170657538
Changed
jz...@google.com added comment #2:
Thanks for the report. There are still some abseil dependencies in gav1_decode.cc as well as a few in some disabled neon debug code. CMake currently doesn't have any code to fully disable abseil if those are disabled too.
_______________________________
jz...@google.com added comment #2:
Thanks for the report. There are still some abseil dependencies in gav1_decode.cc as well as a few in some disabled neon debug code. CMake currently doesn't have any code to fully disable abseil if those are disabled too.
_______________________________
Reference Info: 170657538 Specifying LIBGAV1_THREADPOOL_USE_STD_MUTEX flag doesn't remove dependency on Abseil
status: New
reporter: vi...@gmail.com
cc: ga...@googlegroups.com, vi...@gmail.com
type: Bug
priority: P4
severity: S2
retention: Component default
buganize...@google.com
Oct 13, 2020, 5:17:18 PM10/13/20
to gav1-deve...@googlegroups.com
Replying to this email means your email address will be shared with the team that works on this product.
https://issuetracker.google.com/issues/170657538
Changed
vi...@gmail.com added comment #3:
Thank you for a quick answer.
Probably in this case the comment in README.md about LIBGAV1_THREADPOOL_USE_STD_MUTEX should be corrected.
Regards,
Victor
_______________________________
vi...@gmail.com added comment #3:
Thank you for a quick answer.
Probably in this case the comment in README.md about LIBGAV1_THREADPOOL_USE_STD_MUTEX should be corrected.
Regards,
Victor
_______________________________
Reference Info: 170657538 Specifying LIBGAV1_THREADPOOL_USE_STD_MUTEX flag doesn't remove dependency on Abseil
status: New
reporter: vi...@gmail.com
cc: ga...@googlegroups.com, vi...@gmail.com
type: Bug
priority: P4
severity: S2
retention: Component default
buganize...@google.com
Dec 10, 2020, 3:17:02 PM12/10/20
to gav1-deve...@googlegroups.com
Replying to this email means your email address will be shared with the team that works on this product.
https://issuetracker.google.com/issues/170657538
Changed
jz...@google.com added comment #4:
commit bd71f75fb5dccb198c139d06e65c86a6659ac326
Author: James Zern <jz...@google.com>
Date: Fri Dec 4 14:56:49 2020 -0800
cmake: explicitly fail w/missing abseil
+ add some instructions on the dependency and how to resolve the failure
Bug: b/170657538
PiperOrigin-RevId: 345763071
Change-Id: I1e70063c9b9f38cc77075992f9b02093e7abeea5
_______________________________
jz...@google.com added comment #4:
commit bd71f75fb5dccb198c139d06e65c86a6659ac326
Author: James Zern <jz...@google.com>
Date: Fri Dec 4 14:56:49 2020 -0800
cmake: explicitly fail w/missing abseil
+ add some instructions on the dependency and how to resolve the failure
Bug: b/170657538
PiperOrigin-RevId: 345763071
Change-Id: I1e70063c9b9f38cc77075992f9b02093e7abeea5
_______________________________
Reference Info: 170657538 Specifying LIBGAV1_THREADPOOL_USE_STD_MUTEX flag doesn't remove dependency on Abseil
status: New
reporter: vi...@gmail.com
cc: ga...@googlegroups.com, vi...@gmail.com
type: Bug
priority: P4
severity: S2
retention: Component default
buganize...@google.com
Apr 5, 2021, 10:56:26 PM4/5/21
to gav1-deve...@googlegroups.com
Replying to this email means your email address will be shared with the team that works on this product.
https://issuetracker.google.com/issues/170657538
Changed
status: New → Assigned
assignee: <none> → jz...@google.com
jz...@google.com added comment #5:
commit e8d6a80f5b495077937ca6a1b1e65e6e9fb61776
Author: James Zern <jz...@google.com>
Date: Mon Apr 5 19:07:08 2021 -0700
README.md: clarify Abseil requirement
abseil is required by the examples and tests unconditionally and by
libgav1 if LIBGAV1_THREADPOOL_USE_STD_MUTEX is set to 0 (the default on
all platforms except Android & iOS).
+ reflow LIBGAV1_MAX_THREADS entry to quiet a lint check
Bug: b/170657538
PiperOrigin-RevId: 366919634
Change-Id: If3be651fbd26677c1f2aa61221fd75baefc7ad2b
_______________________________
status: New → Assigned
assignee: <none> → jz...@google.com
jz...@google.com added comment #5:
commit e8d6a80f5b495077937ca6a1b1e65e6e9fb61776
Author: James Zern <jz...@google.com>
Date: Mon Apr 5 19:07:08 2021 -0700
README.md: clarify Abseil requirement
abseil is required by the examples and tests unconditionally and by
libgav1 if LIBGAV1_THREADPOOL_USE_STD_MUTEX is set to 0 (the default on
all platforms except Android & iOS).
+ reflow LIBGAV1_MAX_THREADS entry to quiet a lint check
Bug: b/170657538
PiperOrigin-RevId: 366919634
Change-Id: If3be651fbd26677c1f2aa61221fd75baefc7ad2b
_______________________________
Reference Info: 170657538 Specifying LIBGAV1_THREADPOOL_USE_STD_MUTEX flag doesn't remove dependency on Abseil
cc: ga...@googlegroups.com, vi...@gmail.com
type: Bug
priority: P4
severity: S2
retention: Component default
Reply all
Reply to author
Forward
0 new messages