TAB menu takes long to open

[Carlo Giesa]

Hi there!

We regularly encounter long delays when hitting TAB in the node graph to open the node creation menu. I ran a profile and saw that there is some os._walk going on each time, the menu gets opened. Here's my visual profile:

Is this expected behavior? On our side, this can sometimes take multiple seconds. What is the exact purpose of this? Couldn't the crawling happen once and be stored in memory?

Greets,
Carlo

[Martino Madeddu]

Could be totally unrelated but i had an issue on Linux where the tab menu would get progressively slower as i did custom OSL inline.
Gaffer saves compiled OSL in folders and that folder apparently gets scanned by the tab menu (which would show up as os operations).

I could fix it locally by going into my user folder and manually deleting the oslCode generated and the tab menu would get instant again.

on linux the folders to delete were in: /users/myname/gaffer/oslCode

here is the Discord conversation with John aswell:

https://discord.com/channels/722635732384219146/1333442057330753628

chhers

	​​​​
Martino Madeddu  |  VFX Supervisor Untold Studios. White Collar Factory | 1 Old Street Yard | London | EC1Y 8AF +44 7526 594 487  |  +44 208 016 6111 untoldstudios.tv

--
You received this message because you are subscribed to the Google Groups "gaffer-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gaffer-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/gaffer-dev/2ea98079-4628-4d42-a5e6-a60e12b24230n%40googlegroups.com.

--

	​​​​
Martino Madeddu  |  VFX Supervisor Untold Studios. White Collar Factory | 1 Old Street Yard | London | EC1Y 8AF +44 7526 594 487  |  +44 208 016 6111 untoldstudios.tv

[Carlo Giesa]

Oh yes, indeed, there were a lot of folders inside of it. Now, it opens instantly again. Thanks for sharing!

Greets,

Carlo

To view this discussion visit https://groups.google.com/d/msgid/gaffer-dev/CAE9LL_-29_X4JMGeQF%3Db4KVqrBa72m-xb8Pug2zXMSKGEJE-5w%40mail.gmail.com.

[Carlo Giesa]

Any clue what the content of this folder contains? I just deleted everything but I'm not sure if that was/is important at some point. :/

[Martino Madeddu]

Glad it worked,

Feels like an issue worth resolving globally to me. i thought  I was a special unlucky case but i reckon it happens to many people (to different degrees depending on network).

I'll let the Gaffer guys really answer your question but i don't think those files are crucial for anything else than live rendering. They should just be files generated by the inline OSL when you process it. So next time you run the OSL code it will re-create them.

John did give me a more permanent solution to this which i applied and it worked well for me. 
Here the message from John on Discord:
Yep, those are made by the OSLCode node. It's interesting that it was so slow for you to index those files - we haven't noticed the same problem, but maybe we've just been getting lucky. It looks like the other solution might be to remove this line from the wrapper : . Doing some code archeology it looks like it was needed when first introduced, but may not be needed now at all. Removing it would mean that that directory wouldn't be visited by the menu code at all.

	​​​​
Martino Madeddu  |  VFX Supervisor Untold Studios. White Collar Factory | 1 Old Street Yard | London | EC1Y 8AF +44 7526 594 487  |  +44 208 016 6111 untoldstudios.tv

To view this discussion visit https://groups.google.com/d/msgid/gaffer-dev/CANHZvCMNpbXOSrfHOkDhAUjowrButWsr9iB4rBOmnYv20-wGWA%40mail.gmail.com.

[John Haddon]

I opened a pull request with the fix I was talking about above : https://github.com/GafferHQ/gaffer/pull/6891. If you were able to test it before it gets merged, that would be very helpful.

Cheers...

John

To view this discussion visit https://groups.google.com/d/msgid/gaffer-dev/CAE9LL_-3Nu%2B%3DZbXdDPEdMO2qrxcT5ZXb179d6-g641TNiBrJPw%40mail.gmail.com.

[Carlo Giesa]

Great news! Thanks John! Not sure if I'll be able to test this before getting merged in. Sorry.

Greets,

Carlo

You received this message because you are subscribed to a topic in the Google Groups "gaffer-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/gaffer-dev/W-A3jVxfKj4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to gaffer-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/gaffer-dev/CAB8pVg%2BPdn2u0wA8TR2JLCKDX-cAvrttM%2BQ2dEFLC3CHMBCNKw%40mail.gmail.com.