[GafferHQ/gaffer] e83940: EditScopeUI : Fix bug handling read-only ScriptNodes

0 views
Skip to first unread message

Murray Stevenson

unread,
Dec 12, 2024, 8:11:33 PM12/12/24
to gaffer-...@googlegroups.com
Branch: refs/heads/1.5_maintenance
Home: https://github.com/GafferHQ/gaffer
Commit: e8394091c6f836dabe0c935bdf9978258a75dfe6
https://github.com/GafferHQ/gaffer/commit/e8394091c6f836dabe0c935bdf9978258a75dfe6
Author: John Haddon <thehad...@gmail.com>
Date: 2024-12-12 (Thu, 12 Dec 2024)

Changed paths:
M Changes.md
M python/GafferUI/EditScopeUI.py

Log Message:
-----------
EditScopeUI : Fix bug handling read-only ScriptNodes

In this case `relativeName()` was throwing due to the ScriptNode not being a child of itself. I wasn't really sure what name to use here - the node name itself isn't really meaningful, and `ScriptNode` might not mean much to a user. In practice ScriptNodes are only read-only when the file on the filesystem is read-only, so I went with "File" as hopefully being the most self-explanatory.


Commit: 1dc7d84750fe46bac0bc2b6ece1eef2e3eb97b2e
https://github.com/GafferHQ/gaffer/commit/1dc7d84750fe46bac0bc2b6ece1eef2e3eb97b2e
Author: Murray Stevenson <50844517+mur...@users.noreply.github.com>
Date: 2024-12-12 (Thu, 12 Dec 2024)

Changed paths:
M Changes.md
M python/GafferUI/EditScopeUI.py

Log Message:
-----------
Merge pull request #6185 from johnhaddon/globalEditTargetFix

EditScopeUI : Fix bug handling read-only ScriptNodes


Compare: https://github.com/GafferHQ/gaffer/compare/4558478b55bf...1dc7d84750fe

To unsubscribe from these emails, change your notification settings at https://github.com/GafferHQ/gaffer/settings/notifications
Reply all
Reply to author
Forward
0 new messages