[GafferHQ/gaffer] 1d8403: RandomChoiceUI : Fix handling of non-ValuePlugs

0 views
Skip to first unread message

Eric Mehl

unread,
Dec 10, 2024, 3:40:53 PM12/10/24
to gaffer-...@googlegroups.com
Branch: refs/heads/1.4_maintenance
Home: https://github.com/GafferHQ/gaffer
Commit: 1d8403c912e060f0a31a94ee676ed2e9335ea9e2
https://github.com/GafferHQ/gaffer/commit/1d8403c912e060f0a31a94ee676ed2e9335ea9e2
Author: John Haddon <thehad...@gmail.com>
Date: 2024-12-10 (Tue, 10 Dec 2024)

Changed paths:
M Changes.md
M python/GafferUI/RandomChoiceUI.py

Log Message:
-----------
RandomChoiceUI : Fix handling of non-ValuePlugs

Right-clicking on (for example) a `ShaderAssignment.shader` plug in the NodeEditor was leading to the following warning :

```
ERROR : Plug menu : Traceback (most recent call last):
ERROR : File "/home/john/dev/build/gaffer-1.4/python/GafferUI/PlugValueWidget.py", line 994, in __combiner
ERROR : next( results )
ERROR : IECore.Exception: Traceback (most recent call last):
ERROR : File "/home/john/dev/build/gaffer-1.4/python/GafferUI/RandomChoiceUI.py", line 245, in __popupMenu
ERROR : if not Gaffer.RandomChoice.canSetup( plug ) :
ERROR : Boost.Python.ArgumentError: Python argument types in
ERROR : RandomChoice.canSetup(ShaderPlug)
ERROR : did not match C++ signature:
ERROR : canSetup(Gaffer::ValuePlug const*)
```


Commit: 2e0c9ca5eefc9ad9702a2452f88790a6bf8536cb
https://github.com/GafferHQ/gaffer/commit/2e0c9ca5eefc9ad9702a2452f88790a6bf8536cb
Author: Eric Mehl <er...@cinesite.com>
Date: 2024-12-10 (Tue, 10 Dec 2024)

Changed paths:
M Changes.md
M python/GafferUI/RandomChoiceUI.py

Log Message:
-----------
Merge pull request #6180 from johnhaddon/randomChoiceUIFix

RandomChoiceUI : Fix handling of non-ValuePlugs


Compare: https://github.com/GafferHQ/gaffer/compare/fe384e413de3...2e0c9ca5eefc

To unsubscribe from these emails, change your notification settings at https://github.com/GafferHQ/gaffer/settings/notifications
Reply all
Reply to author
Forward
0 new messages