[GafferHQ/gaffer] 300dda: CatalogueUI : Don't "steal" irrelevant drags

[John Haddon]

Branch: refs/heads/1.4_maintenance
Home: https://github.com/GafferHQ/gaffer
Commit: 300dda0b3ded7d82a9e31f47a3fd0280e8d3ace2
https://github.com/GafferHQ/gaffer/commit/300dda0b3ded7d82a9e31f47a3fd0280e8d3ace2
Author: John Haddon <thehad...@gmail.com>
Date: 2024-12-09 (Mon, 09 Dec 2024)

Changed paths:
M Changes.md
M python/GafferImageUI/CatalogueUI.py

Log Message:
-----------
CatalogueUI : Don't "steal" irrelevant drags

We were accepting any drag which provided StringVectorData, when we should only have been accepting those which originated in the image listing (because we are using the drag to reorder images). This meant we were accepting drags of paths from the HierarchyView, and then clobbering the custom pointer in `__pathListingDragLeave`. This gave people the impression that the drag was broken, when in fact you could still continue and drop elsewhere (despite the pointer indicating otherwise).

Also tweaked the drag move logic so we use exactly the same checks in both enter and move.


Commit: dc38e12468bd1e3ecfe3e73468cf1a54bf8f5948
https://github.com/GafferHQ/gaffer/commit/dc38e12468bd1e3ecfe3e73468cf1a54bf8f5948
Author: John Haddon <thehad...@gmail.com>
Date: 2024-12-09 (Mon, 09 Dec 2024)

Changed paths:
M Changes.md
M python/GafferImageUI/CatalogueUI.py

Log Message:
-----------
Merge pull request #6168 from johnhaddon/catalogueDragFix

CatalogueUI : Don't "steal" irrelevant drags


Compare: https://github.com/GafferHQ/gaffer/compare/f45b0f11d913...dc38e12468bd

To unsubscribe from these emails, change your notification settings at https://github.com/GafferHQ/gaffer/settings/notifications