Re: Enable Django admin site for Rietveld example (issue3982041)

[albrec...@googlemail.com]

Looks good to me, but without testing it. I cannot apply the patch for
some reason... :-(

http://codereview.appspot.com/3982041/

[tech...@gmail.com]

What tool do you use for patching? My python-patch complains only about
"\ No newline at end of file" string at the end, but it's normal,
because not supported.

http://codereview.appspot.com/3982041/

[Andi Albrecht]

I've just downloaded the patch and tried to apply it.
Here's the output. Working directory is the root directory in trunk:

$ svn info|grep Revisionon
Revision: 155

$ curl http://codereview.appspot.com/download/issue3982041_1.diff | patch
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1546 0 1546 0 0 4486 0 --:--:-- --:--:-- --:--:-- 5725
patching file urls.py
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 10.
2 out of 2 hunks FAILED -- saving rejects to file urls.py.rej
patching file settings.py
Hunk #1 FAILED at 71.
1 out of 1 hunk FAILED -- saving rejects to file settings.py.rej
patching file TODO
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file TODO.rej

[Mark Roddy]

If it's a subversion generated diff you need to specify '-p0' to the
patch command. Try this:
curl http://codereview.appspot.com/download/issue3982041_1.diff | patch -p0

-Mark

[Andi Albrecht]

On Wed, Jan 19, 2011 at 1:22 AM, Mark Roddy <mark...@gmail.com> wrote:
> If it's a subversion generated diff you need to specify '-p0' to the
> patch command.  Try this:
> curl http://codereview.appspot.com/download/issue3982041_1.diff | patch -p0

hehe, sure, thanks :)

committed r156.

[tech...@gmail.com]

That's why I've created python-patch. =)

Thanks for reviews.

http://codereview.appspot.com/3982041/