Issue 31 in django-gae2django: examples/rietveld/UPDATES should mention patchset.owner_id is deprecated

5 views
Skip to first unread message

django-g...@googlecode.com

unread,
Dec 13, 2011, 6:35:09 AM12/13/11
to gae2d...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 31 by arkadi.s...@gmail.com: examples/rietveld/UPDATES should
mention patchset.owner_id is deprecated
http://code.google.com/p/django-gae2django/issues/detail?id=31

Rietveld revision 59805f019927 removed patchset.owner_id NOT NULL column
from database.
http://code.google.com/p/rietveld/source/detail?r=59805f019927c0fab9ade939aa1f726fae75efdb&path=/codereview/models.py
So UPDATES file should mention the owner_id must be removed or it will fail
with
codereview_patchset.owner_id may not be NULL
error while submitting the issue.
Instructions for sqlite in patch.


Attachments:
UPDATES.diff 1.6 KB

django-g...@googlecode.com

unread,
Dec 13, 2011, 6:39:14 AM12/13/11
to gae2d...@googlegroups.com

Comment #1 on issue 31 by arkadi.s...@gmail.com: examples/rietveld/UPDATES
should mention patchset.owner_id is deprecated
http://code.google.com/p/django-gae2django/issues/detail?id=31

(No comment was entered for this change.)

Attachments:
UPDATES.diff 1.5 KB

django-g...@googlecode.com

unread,
Dec 14, 2011, 2:56:27 AM12/14/11
to gae2d...@googlegroups.com
Updates:
Status: Fixed

Comment #2 on issue 31 by albrecht.andi: examples/rietveld/UPDATES should

This issue was closed by revision e4cb36736569.

django-g...@googlecode.com

unread,
Dec 14, 2011, 3:00:30 AM12/14/11
to gae2d...@googlegroups.com

Comment #3 on issue 31 by albrecht.andi: examples/rietveld/UPDATES should

Thanks! I've uploaded a different version. The SQL statements in the UPDATE
file target PostgreSQL. But I've mentioned your approach for SQLite in the
commit message.

Reply all
Reply to author
Forward
0 new messages