Patch admin/login links and allow change passwords (issue4000044)

tech...@gmail.com

unread,

Jan 20, 2011, 5:37:22 PM1/20/11

to albrec...@googlemail.com, gae2d...@googlegroups.com, re...@codereview.appspotmail.com

Reviewers: Andi Albrecht,

Please review this at http://codereview.appspot.com/4000044/

Affected files:
M examples/rietveld/README
A examples/rietveld/patches/account-login-links.diff

Index: examples/rietveld/patches/account-login-links.diff
===================================================================
--- examples/rietveld/patches/account-login-links.diff (revision 0)
+++ examples/rietveld/patches/account-login-links.diff (revision 0)
@@ -0,0 +1,34 @@
+Index: templates/issue_base.html
+===================================================================
+--- templates/issue_base.html (revision 647)
++++ templates/issue_base.html (working copy)
+@@ -28,8 +28,7 @@
+ <a class="novisit" href="{%url codereview.views.index%}?closed=1">All
Issues</a>
+ |
+ <a class="novisit" href="{{sign_in}}">Sign in</a>
+- with your <a href="https://www.google.com/accounts/NewAccount">Google
+- Account</a> to create issues and add comments
++ to create issues and add comments
+ {%endif%}
+ {%endblock%}
+
+Index: templates/base.html
+===================================================================
+--- templates/base.html (revision 647)
++++ templates/base.html (working copy)
+@@ -168,10 +168,14 @@
+ <a class="novisit" href="{%url codereview.views.settings%}">Settings</a>
+ |
+ {%endif%}
+-{%if is_dev%}
++{%if is_dev or user.is_superuser%}
+ <a class="novisit" target="_blank" href="/_ah/admin">Admin</a>
+ |
+ {%endif%}
++{%if user%}
++<a class="novisit" target="_blank" href="/admin/password_change">Change
password</a>
++|
++{%endif%}
+ <a class="novisit" target="_blank"
+ href="http://code.google.com/p/rietveld/wiki/CodeReviewHelp">Help</a>
+ |
Index: examples/rietveld/README
===================================================================
--- examples/rietveld/README (revision 157)
+++ examples/rietveld/README (working copy)
@@ -62,9 +62,10 @@

Then modify your checked out version of Rietveld by applying all patches
-in the patches directory (so far there is only one).
+in the patches directory.

patch -p0 < patches/upload.diff
+ patch -p0 < patches/account-login-links.diff

Finally run