Re: Issue 25 in django-gae2django: Rietveld example: fix download link for upload.py if app is running on production

5 views
Skip to first unread message

django-g...@googlecode.com

unread,
Jan 13, 2011, 12:02:28 PM1/13/11
to gae2d...@googlegroups.com

Comment #3 on issue 25 by techtonik: Rietveld example: fix download link
for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

The proper patch for current Rietveld to be added to examples.

Attachments:
download.link.diff 3.6 KB

django-g...@googlecode.com

unread,
Jan 13, 2011, 3:03:05 PM1/13/11
to gae2d...@googlegroups.com

Comment #4 on issue 25 by albrecht.andi: Rietveld example: fix download
link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

Is this issue still valid?

django-g...@googlecode.com

unread,
Jan 13, 2011, 5:20:39 PM1/13/11
to gae2d...@googlegroups.com

Comment #5 on issue 25 by techtonik: Rietveld example: fix download link
for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

Yes, and the settings.py modifications too. The patch is changed though -
see attach. It may be reduced through
http://codereview.appspot.com/3996041/ but unlikely to be gone.

Attachments:
download.link.diff 1.1 KB

django-g...@googlecode.com

unread,
Jan 17, 2011, 9:54:27 AM1/17/11
to gae2d...@googlegroups.com

Comment #6 on issue 25 by techto...@gmail.com: Rietveld example: fix
download link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

All patches that were possible to integrate to Rietveld codebase were
integrated. This is what is left to enable download link for upload.py in
standalone Django instances.

Attachments:
download.link.diff 459 bytes

django-g...@googlecode.com

unread,
Jan 21, 2011, 4:10:30 PM1/21/11
to gae2d...@googlegroups.com
Updates:
Status:
Labels: -Type-Defect -Priority-Medium

Comment #7 on issue 25 by techto...@gmail.com: Rietveld example: fix

download link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

Proper review uploaded http://codereview.appspot.com/4095042

django-g...@googlecode.com

unread,
Jan 22, 2011, 4:56:33 PM1/22/11
to gae2d...@googlegroups.com
Updates:
Status: Fixed

Comment #8 on issue 25 by techto...@gmail.com: Rietveld example: fix

download link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

This issue was closed by revision r163.

django-g...@googlecode.com

unread,
Jan 22, 2011, 5:01:35 PM1/22/11
to gae2d...@googlegroups.com
Updates:
Status: Accepted

Comment #9 on issue 25 by techto...@gmail.com: Rietveld example: fix

download link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

Fixed only for manual mode, Makefile still needs a fix.

django-g...@googlecode.com

unread,
Jan 25, 2011, 1:49:35 PM1/25/11
to gae2d...@googlegroups.com

Comment #10 on issue 25 by techto...@gmail.com: Rietveld example: fix
download link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

Fixed in r164.

django-g...@googlecode.com

unread,
Jan 25, 2011, 1:53:45 PM1/25/11
to gae2d...@googlegroups.com
Updates:
Status: Fixed

Comment #11 on issue 25 by techto...@gmail.com: Rietveld example: fix

download link for upload.py if app is running on production
http://code.google.com/p/django-gae2django/issues/detail?id=25

(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages