ImageFormat.h not built, causing build failure; other minor mismatch of docs and build

[Eric Haines]

First, here's minor mismatch between the documentation and what the installer does:

This docs page, G3D 10 Build System Instructions, says:

Set the user environment variable G3D10DATA to  %g3d%\G3D10\data-files;%g3d%\data10\common;%g3d%\data10\game;%g3d%\data10\research

but installg3dwin.hta sets:

%g3d%\G3D10\data-files;%g3d%\data10\common;%g3d%\data10\research;%g3d%\data10\game

The order of the last two is swapped. Doesn't seem to matter, but I thought you should know. I was checking the variable because of the build failure I had.


The second problem is that installg3dwin.hta 99.9% worked, but when I tried "buildg3d local", as the documentation above recommends, the build was missing ImageFormat.h. Searching this google group, I see that this file is supposed to automatically get built. It did not on my machine. I searched my whole machine - it did not exist. I finally copied it directly from https://casual-effects.com/g3d/G3D10/G3D-base.lib/include/G3D-base/ImageFormat.h and then the build worked fine.

Thought you should know. You might want to try building G3D on a clean machine, if you want to reproduce the error. I didn't change any defaults.

Eric

Here's the error log when I built manually (all the builds prior to these two built fine):

"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild" VisualStudio\G3D.sln /p:Configuration=Debug /t:"External Libraries\waveVK_lib" /p:Platform="x64" /fl

Microsoft (R) Build Engine version 16.11.0+0538acc04 for .NET Framework

Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.

Build started 10/25/2021 11:53:20 AM.

Project "C:\g3d\G3D10\VisualStudio\G3D.sln" on node 1 (External Libraries\waveVK_lib target(s)).

ValidateSolutionConfiguration:

  Building solution configuration "Debug|x64".

ValidateProjects:

  The project "Documentation" is not selected for building in solution configuration "Debug|x64".

  The project "Build Files" is not selected for building in solution configuration "Debug|x64".

  The project "scratch-michael" is not selected for building in solution configuration "Debug|x64".

  The project "tbb.dll" is not selected for building in solution configuration "Debug|x64".

  The project "tbbmalloc.dll" is not selected for building in solution configuration "Debug|x64".

Project "C:\g3d\G3D10\VisualStudio\G3D.sln" (1) is building "C:\g3d\G3D10\VisualStudio\waveVK.lib.vcxproj" (2) on node

1 (default targets).

InitializeBuildStatus:

  Touching "C:\g3d\G3D10\VisualStudio\\temp\Debug\waveVK.lib.tlog\unsuccessfulbuild".

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\CL.exe /c /ZI

   /nologo /W3 /WX- /diagnostics:column /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D _USE_MATH_DEFINES /D NOMINMAX /D GLUT_FOUN

  D /D GLUT_NO_LIB_PRAGMA /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /arch:AVX2 /fp:precise /Zc:wch

  ar_t /Zc:forScope /Zc:inline /GR /Fo"C:\g3d\G3D10\VisualStudio\\temp\Debug\\" /Fd"C:\g3d\G3D10\VisualStudio\\..\build

  \lib\waveVKd.pdb" /external:W3 /Gd /TP /wd4355 /wd4996 /FC /errorReport:queue ..\external\waveVK.lib\source\nv_helper

  s_vk\TopLevelASGenerator.cpp ..\external\waveVK.lib\source\waveVK.cpp

  TopLevelASGenerator.cpp

  waveVK.cpp

C:\g3d\G3D10\G3D-base.lib\include\G3D-base\Image.h(20,10): fatal error C1083: Cannot open include file: 'G3D-base/Image

Format.h': No such file or directory (compiling source file ..\external\waveVK.lib\source\waveVK.cpp) [C:\g3d\G3D10\Vis

ualStudio\waveVK.lib.vcxproj]

C:\g3d\G3D10\G3D-base.lib\include\G3D-base\Image.h(20,10): fatal error C1083: Cannot open include file: 'G3D-base/Image

Format.h': No such file or directory (compiling source file ..\external\waveVK.lib\source\nv_helpers_vk\TopLevelASGener

ator.cpp) [C:\g3d\G3D10\VisualStudio\waveVK.lib.vcxproj]

Done Building Project "C:\g3d\G3D10\VisualStudio\waveVK.lib.vcxproj" (default targets) -- FAILED.

Done Building Project "C:\g3d\G3D10\VisualStudio\G3D.sln" (External Libraries\waveVK_lib target(s)) -- FAILED.

Build FAILED.

"C:\g3d\G3D10\VisualStudio\G3D.sln" (External Libraries\waveVK_lib target) (1) ->

"C:\g3d\G3D10\VisualStudio\waveVK.lib.vcxproj" (default target) (2) ->

(ClCompile target) ->

  C:\g3d\G3D10\G3D-base.lib\include\G3D-base\Image.h(20,10): fatal error C1083: Cannot open include file: 'G3D-base/Ima

geFormat.h': No such file or directory (compiling source file ..\external\waveVK.lib\source\waveVK.cpp) [C:\g3d\G3D10\V

isualStudio\waveVK.lib.vcxproj]

  C:\g3d\G3D10\G3D-base.lib\include\G3D-base\Image.h(20,10): fatal error C1083: Cannot open include file: 'G3D-base/Ima

geFormat.h': No such file or directory (compiling source file ..\external\waveVK.lib\source\nv_helpers_vk\TopLevelASGen

erator.cpp) [C:\g3d\G3D10\VisualStudio\waveVK.lib.vcxproj]

    0 Warning(s)

    2 Error(s)

Time Elapsed 00:00:01.47

20s

Note: build target failed with code 1

C:\g3d\G3D10>

[Andrzej Lichnerowicz]

Just +1, to validate that I've seen the same on revision 7185, and copying the file works like a charm. Wouldn't have guessed it, so thanks a lot!

--&.

[Morgan McGuire]

Thanks.

I haven't been able to reproduce this on any system (mac, linux, various windows versions) so I haven't been able to patch for the case where it happens yet...and I know of a handful of others who had the problem.

However, we're rewriting the entire installer this month an upgrading to VS 17 on Windows and cleaning the project files in the process, so I hope that will catch the issue.

-m

--
You received this message because you are subscribed to the Google Groups "G3D Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to g3d-users+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/g3d-users/c8830d8e-9036-4b25-9d0e-076f8d84a674n%40googlegroups.com.

[Eric Haines]

OK, thanks for the update. Not a big deal (I just copied the file), but I thought I'd report it.

To view this discussion on the web visit https://groups.google.com/d/msgid/g3d-users/CAPm8QNtiGS2GxugghVPLKMH6GfienURGA2rQzBwVTJcsbtvrPQ%40mail.gmail.com.

[Andrzej Lichnerowicz]

FWIW, for me it was fresh first-time-ever checkout, Python 3.10, TortoiseSVN (installed via scoop in custom location), VS Community 2019 16.11.8. Done manually, because Installer didn't catch none of the system components (neither Python, nor SVN nor VS).  (Like Eric said,  not a big deal)

If you want me to send some logs, like cmake build folder, I'd be glad to help. Also, let me take this opportunity to thank you Morgan for the amazing work :)

---&.

[Guillem Pérez Delgado]

Hi, just posting to let you guys know that this issue is still present in revision 7186 (following the G3D 10 Build System Instructions - Windows Manual).

The solution provided by Eric works perfectly, thanks!

[Guillem Pérez Delgado]

Hi, just posting to let you guys know that this issue is stille present on revision 7186 (following the G3D 10 Build System Instructions - Windows Manual).

The solution provided by Eric works perfectly, thanks!

On Sunday, January 9, 2022 at 10:12:57 PM UTC+1 unj...@gmail.com wrote:

[Julien Matthey]

Same issue here.

I just pulled a fresh G3D from svn and ran "buildg3d local" and had the issue (building on Windows 10/msvc). ImageFormat.h/.cpp are *not* versioned.

I copied the 2 files from https://casual-effects.com/g3d/... and it did the trick.

Are those 2 files supposed to be generated by the build system?

[Linwan Song]

Just posting here to let everyone know that this issue was fixed in commit 7191.

- Linwan