MoveGeneratorCombinator documentation discrepancy

[Robert Koch]

Hey everyone,

It looks like "MoveGeneratorCombinator" is looking for the kwarg "combination" but the documentation here still states it's looking for the kwarg "collection"

Just a heads up.

cheers,

Rob

[Bachir Aoun]

Hi Robert,

Thank you for sharing :) i hope everyone does the same ...

i am not sure what documentation are you referring to though. on my end the documentation is up to date. see screenshot attached. Am i looking at the correct thing ?

[Robert Koch]

Hi Bachir,

No worries! we're all in this together, afterall.

If one goes here:

https://bachiraoun.github.io/fullrmc/fullrmc.Generators.html

one finds the following code:

for g in ENGINE.groups:
    # create translation generator
    TMG = TranslationGenerator(amplitude=0.2)
    # create rotation generator only when group length is bigger than 1.
    if len(g)>1:
        RMG = RotationGenerator(amplitude=2)
        MG  = MoveGeneratorCombinator(collection=[TMG,RMG],shuffle=True)
    else:
        MG  = MoveGeneratorCombinator(collection=[TMG],shuffle=True)
    g.set_move_generator( MG )

Which i think, strictly speaking, will not run in the current version.as MoveGeneratorCombinator is passed the collection kwarg.

So, it looks like the documentation proper is correct, but the example has an error.

Cheers,

Rob

[Bachir Aoun]

Oh yeah, will fix this example snippet ! thanks