New fork, greek localization and a bit of CSS work

22 views
Skip to first unread message

humbucker

unread,
Sep 26, 2012, 10:33:43 AM9/26/12
to fulcru...@googlegroups.com
Hi all, just chiming in to introduce our Fulcrum fork.


We have added greek locale files, a few view tweaks to facilitate a smoother localization experience, and a few CSS tweaks - basically, we considerably reduced the amount of *bold* text, as we found it difficult to focus on the on-screen data.

Have a look and let me know if any of this sounds interesting, and I can post a pull request.
We also plan to add in a few features:
  - Session variable that keeps last active panel settings
  - Keyboard shortcuts
  - a simple project reporting page

Thank you for a great project!

Malcolm Locke

unread,
Sep 27, 2012, 5:11:16 AM9/27/12
to fulcru...@googlegroups.com
On Wed, Sep 26, 2012 at 07:33:43AM -0700, humbucker wrote:
> Hi all, just chiming in to introduce our Fulcrum fork.
>
> https://github.com/Achillefs/fulcrum
>
> We have added greek locale files, a few view tweaks to facilitate a
> smoother localization experience, and a few CSS tweaks - basically, we
> considerably reduced the amount of *bold* text, as we found it difficult to
> focus on the on-screen data.

Excellent work, thanks Humbucker (Achilles?).

> Have a look and let me know if any of this sounds interesting, and I can
> post a pull request.

I've merged the i18n and 'de-bolding' commits from your fork, many
thanks.

> We also plan to add in a few features:
> - Session variable that keeps last active panel settings
> - Keyboard shortcuts
> - a simple project reporting page

All sound good to me. If you work on each as a feature branch it will
make the pull request process a lot easier and increase the chance of a
swift and pain free merge into the mainline.

Welcome to the contributor list ;)

Malc

Malcolm Locke

unread,
Sep 27, 2012, 5:48:20 AM9/27/12
to fulcru...@googlegroups.com
On Thu, Sep 27, 2012 at 09:11:16PM +1200, Malcolm Locke wrote:
> On Wed, Sep 26, 2012 at 07:33:43AM -0700, humbucker wrote:
> > We have added greek locale files, a few view tweaks to facilitate a
> > smoother localization experience, and a few CSS tweaks - basically, we
> > considerably reduced the amount of *bold* text, as we found it difficult to
> > focus on the on-screen data.
>
> Excellent work, thanks Humbucker (Achilles?).
>
> > Have a look and let me know if any of this sounds interesting, and I can
> > post a pull request.
>
> I've merged the i18n and 'de-bolding' commits from your fork, many
> thanks.

The changes in `config/initializers/inflections.rb` seem to have broken
the Ruby 1.8.7 build, see
http://travis-ci.org/#!/malclocke/fulcrum/jobs/2580053

The error is:

unmatched (: /(�)\271στορία$/

Any ideas on a quick solution to this? I think I'm probably OK at this
point with dropping 1.8.7 support if it's necessary, but I'd like to
keep it if possible.

Malc

humbucker

unread,
Sep 27, 2012, 6:23:13 AM9/27/12
to fulcru...@googlegroups.com
Hey Malc, thanks for welcome.

No worries regarding the new features, I will do them in branches.

Regarding the errors, it is a utf-related issue, as 1.8.* and 1.9.* are quite different in the way they handle UTF sources.
I will post a fix in a few hours.

thanks,
ac

humbucker

unread,
Sep 27, 2012, 8:08:57 AM9/27/12
to fulcru...@googlegroups.com
This should do the trick:

From here on, I ll be working on branches and will issue pull request when new features are completed and tested

ac

Malcolm Locke

unread,
Sep 27, 2012, 5:34:16 PM9/27/12
to fulcru...@googlegroups.com
On Thu, Sep 27, 2012 at 05:08:57AM -0700, humbucker wrote:
> This should do the trick:
> https://github.com/Achillefs/fulcrum/commit/f343b97989224eeea6adf561735ba4a5202291e8

Thanks.

Cherry picked, and all green again ;)

Malc
Reply all
Reply to author
Forward
0 new messages