Code / sanity review?

[Mathias Brandewinder]

Hi everyone,

I have taken my first steps with FAKE recently, trying to get an automated build for a NuGet package for Howard Mansell's R Type Provider (https://github.com/BlueMountainCapital/FSharpRProvider)

I got a first pass working here: https://github.com/mathias-brandewinder/FSharpRProvider

Automated build is not my strong suit, so I would love to get some feedback / sanity check on whether what I did is right, and how to improve it. So far "it works on my machine" and creates a NuGet package in the nuget folder; what I haven't done yet and plan to do next is to replace the hard-coded reference to RDotNet, and automatically pull the corresponding NuGet package.

Any feedback would be really appreciated!

Cheers, and thanks in advance,

Mathias

[Anton Tayanovskyy]

Looks fine to me - the main thing, it should work for you :)

If you want to waste more time on your build process you can check out an experimental feature called FAKE boot workflow (http://t0yv0.blogspot.com/2013/04/introducing-fake-boot-workflow.html). I am a bit OCD with removing binaries from source control, this feature allows you to do that, basically to rely on NuGet to pull binary dependencies, including build dependencies. WebSharper (https://bitbucket.org/IntelliFactory/websharper/src) is currently using this to build itself.

Thanks,

--A

--
Sie haben diese Nachricht erhalten, weil Sie der Google Groups-Gruppe FAKE - F# Make beigetreten sind.
Um Ihr Abonnement für diese Gruppe zu beenden und keine E-Mails mehr von dieser Gruppe zu erhalten, senden Sie eine Email an fsharpMake+...@googlegroups.com.
Weitere Optionen: https://groups.google.com/groups/opt_out
 
 

--
Kind Regards,
Anton Tayanovskyy

WebSharper™ - type-safe JavaScript in F#
http://intellifactory.com

[Mathias Brandewinder]

Thanks for the feedback, glad you didn't spot anything obviously wrong :)

I'll check the boot workflow, I share the same type of compulsion re: binaries, and I wanted to try to pull the R.NET package from NuGet at build time, so this seems very much in line with what I intended my next steps to be!

Thanks again,

Mathias

[Steffen Forkmann]

Hi Mathias,

 

it looks good. Usually I’d put the „Clean“ target to the top of the target order but …

 

Cheers,

Steffen

[Mathias Brandewinder]

Thanks a ton for taking the time to take a look! And glad to hear I didn't do anything wrong :)
Again, awesome job on FAKE, it's great - makes dealing with builds almost a pleasure.

Mathias