[PATCH] Fix 'order' in DihedralGroup
1 view
Skip to first unread message
Qian Yun
7:00 AM (9 hours ago) 7:00 AM
to fricas-devel
The order of the identity element in DihedralGroup should be 1.
- Qian
(issue spotted by LLM)
diff --git a/src/algebra/discrgrp.spad b/src/algebra/discrgrp.spad
index 62c03981..0b060130 100644
--- a/src/algebra/discrgrp.spad
+++ b/src/algebra/discrgrp.spad
@@ -264,7 +264,7 @@
x
order(x:%) : Integer ==
- one? x => 0
+ one? x => 1
one? expb x => 2
n quo gcd(convert expa x, n)
- Qian
(issue spotted by LLM)
diff --git a/src/algebra/discrgrp.spad b/src/algebra/discrgrp.spad
index 62c03981..0b060130 100644
--- a/src/algebra/discrgrp.spad
+++ b/src/algebra/discrgrp.spad
@@ -264,7 +264,7 @@
x
order(x:%) : Integer ==
- one? x => 0
+ one? x => 1
one? expb x => 2
n quo gcd(convert expa x, n)
Reply all
Reply to author
Forward
0 new messages