Re: [fricas/fricas] fix issue #142 (PR #143)

11 views

Skip to first unread message

unread,

Dec 8, 2023, 4:54:01 PM12/8/23

to fricas-devel

Would the attached test be enough?

Ralf

On 11/28/23 01:15, hebisch wrote:
> On Mon, Nov 27, 2023 at 01:43:50PM -0800, Ralf Hemmecke wrote:
>
>>
>> https://github.com/fricas/fricas/pull/143.patch
>> https://github.com/fricas/fricas/pull/143.diff
>
> Change looks good. But we should also add tests.
>

0001-fix-issue-142.patch

unread,

Dec 8, 2023, 5:21:15 PM12/8/23

to fricas...@googlegroups.com

On Fri, Dec 08, 2023 at 10:53:57PM +0100, Ralf Hemmecke wrote:
> Would the attached test be enough?

Yes, please commit.

> On 11/28/23 01:15, hebisch wrote:
> > On Mon, Nov 27, 2023 at 01:43:50PM -0800, Ralf Hemmecke wrote:
> >
> > >
> > > https://github.com/fricas/fricas/pull/143.patch
> > > https://github.com/fricas/fricas/pull/143.diff
> >
> > Change looks good. But we should also add tests.