[PATCH] remove "-n 0" from "xvfb-run"

2 views
Skip to first unread message

Qian Yun

unread,
Nov 6, 2022, 12:07:38 AM11/6/22
to fricas-devel
After recent discussion about xvfb and my testing, I believe it is
correct and safe to remove "-n 0" from "xvfb-run".

This patch should also fix https://github.com/fricas/fricas/issues/57 .

- Qian


==========

diff --git a/INSTALL b/INSTALL
index 257ae8de..a1f719d9 100644
--- a/INSTALL
+++ b/INSTALL
@@ -239,7 +239,7 @@ may be slow.
It is possible to use the "xvfb-run" program, replacing
"make viewports" above by

- xvfb-run -a -n 0 -s '-screen 0 1024x768x24' make viewports
+ xvfb-run -a -s '-screen 0 1024x768x24' make viewports


Algebra optimization
diff --git a/configure b/configure
index 5f484480..3c687071 100755
--- a/configure
+++ b/configure
@@ -6398,7 +6398,7 @@ done

if test -n "$XVFB_RUN"; then
MAYBE_VIEWPORTS=viewports
- XVFB="xvfb-run -a -n 0 -s '-screen 0 1024x768x24'"
+ XVFB="xvfb-run -a -s '-screen 0 1024x768x24'"
else
{ $as_echo "$as_me:${as_lineno-$LINENO}:
HyperDoc graphics must be built separately." >&5
$as_echo "$as_me: HyperDoc graphics must be built separately." >&6;}
diff --git a/configure.ac b/configure.ac
index 8a5237c3..feaf719e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -763,7 +763,7 @@ if test x"$fricas_has_xpm" = xyes; then
AC_CHECK_PROGS([XVFB_RUN], [xvfb-run])
if test -n "$XVFB_RUN"; then
MAYBE_VIEWPORTS=viewports
- XVFB="xvfb-run -a -n 0 -s '-screen 0 1024x768x24'"
+ XVFB="xvfb-run -a -s '-screen 0 1024x768x24'"
else
AC_MSG_NOTICE([HyperDoc graphics must be built
separately.])
fi
diff --git a/src/doc/sphinx/source/install.rst
b/src/doc/sphinx/source/install.rst
index fee915f0..5aefda64 100644
--- a/src/doc/sphinx/source/install.rst
+++ b/src/doc/sphinx/source/install.rst
@@ -268,7 +268,7 @@ It is possible to use the ``xvfb-run`` program,
replacing
``make viewports`` above by
::

- xvfb-run -a -n 0 -s '-screen 0 1024x768x24' make viewports
+ xvfb-run -a -s '-screen 0 1024x768x24' make viewports


Algebra optimization

Ralf Hemmecke

unread,
Nov 6, 2022, 4:29:42 AM11/6/22
to fricas...@googlegroups.com
I agree to this.

Ralf

Waldek Hebisch

unread,
Nov 6, 2022, 1:53:45 PM11/6/22
to fricas...@googlegroups.com
On Sun, Nov 06, 2022 at 12:07:33PM +0800, Qian Yun wrote:
> After recent discussion about xvfb and my testing, I believe it is
> correct and safe to remove "-n 0" from "xvfb-run".
>
> This patch should also fix https://github.com/fricas/fricas/issues/57 .

Look OK.

--
Waldek Hebisch
Reply all
Reply to author
Forward
0 new messages