line breaking feature in writeInputLines

9 views
Skip to first unread message

Qian Yun

unread,
Apr 3, 2024, 11:03:50 PM4/3/24
to fricas-devel
There is a line breaking feature in "writeInputLines":

it tries to break input lines to less than 72 chars,
see variable "breakChars".


This feature never worked. Following patch fixes it,
however I wonder if this "feature" is worth keeping.

- Qian

diff --git a/src/interp/i-syscmd.boot b/src/interp/i-syscmd.boot
index df862af8..3013bd3d 100644
--- a/src/interp/i-syscmd.boot
+++ b/src/interp/i-syscmd.boot
@@ -1380,7 +1380,7 @@ writeInputLines(fn,initial) ==
null fn =>
throwKeyedMsg("S2IH0038", nil) -- missing file name
maxn := 72
- breakChars := [" ","+"]
+ breakChars := [char '" ", char '"+"]
for i in initial..$IOindex - 1 repeat
vecl := first readHiFi i
if STRINGP vecl then vecl := [vecl]

Waldek Hebisch

unread,
Apr 4, 2024, 10:04:19 AM4/4/24
to fricas...@googlegroups.com
On Thu, Apr 04, 2024 at 11:03:42AM +0800, Qian Yun wrote:
> There is a line breaking feature in "writeInputLines":
>
> it tries to break input lines to less than 72 chars,
> see variable "breakChars".
>
>
> This feature never worked. Following patch fixes it,
> however I wonder if this "feature" is worth keeping.

Patch looks OK. I think that this is useful feature.

--
Waldek Hebisch
Reply all
Reply to author
Forward
0 new messages