[PATCH] misc fixes

[Qian Yun]

Some changes are close to typo fixes, some changes are obvious
and self-explanatory.

- Qian

(Disclaimer: this issue is found by LLM, but the analysis and patch
is thoroughly reviewed by me.)

[Waldek Hebisch]

Concerning 'src/aldor/Makefile2.in' I do not know what the changed
line is supposed to do, so no comment on this.

The other ones are clearly good.

> diff --git a/src/aldor/Makefile2.in b/src/aldor/Makefile2.in
> index 6403ba3d..8a70259d 100644
> --- a/src/aldor/Makefile2.in
> +++ b/src/aldor/Makefile2.in
> @@ -48,7 +48,7 @@ al/libfricas.al: $(libfricas_members)
> ar r $@ $+
>
> # From the .ap dependency we get a lot more dependencies, see cliques.mk.
> -$(patsubst %,ao/%.ao,$(aldor_src)): extra_ao_options=
> +$(patsubst %,ao/%.ao,$(aldor_srcs)): extra_ao_options=
> $(patsubst %,ao/%.ao,$(FRICAS_CLIQUES)): extra_ao_options=-Wname=fricas -Mno-abbrev -Mpreview
> .PRECIOUS: ao/%.ao
> ao/%.ao: ap/%.ap
> diff --git a/src/algebra/math_sym.spad b/src/algebra/math_sym.spad
> index e5d75c69..64fffe1a 100644
> --- a/src/algebra/math_sym.spad
> +++ b/src/algebra/math_sym.spad
> @@ -152,7 +152,7 @@ MathematicalSymbols() : with
> phi(): Symbol == getUTF(966)
> chi(): Symbol == getUTF(967)
> psi(): Symbol == getUTF(968)
> - omega(): Symbol == getUTF(669)
> + omega(): Symbol == getUTF(969)
> Alpha(): Symbol == getUTF(913)
> Beta(): Symbol == getUTF(914)
> Gamma(): Symbol == getUTF(915)
> diff --git a/src/interp/bc-misc.boot b/src/interp/bc-misc.boot
> index b150a6a9..5222e80a 100644
> --- a/src/interp/bc-misc.boot
> +++ b/src/interp/bc-misc.boot
> @@ -571,7 +571,7 @@ bcSeries() ==
> (text . "Create a series by: ")
> (text . "\beginmenu")
> (text . "\item ")
> - (bcLinks ("\menuitemstyle{Expansion}" "" bcSeriesExpansion NILl))
> + (bcLinks ("\menuitemstyle{Expansion}" "" bcSeriesExpansion NIL))
> (text . "\tab{11}Expand a function in a series around a point")
> (text . "\item ")
> (bcLinks ("\menuitemstyle{Formula}" "" bcSeriesByFormula NIL))
> @@ -727,7 +727,7 @@ bcPuiseuxSeries(a, b) ==
> (isDomain S (String))
> (isDomain I (Integer))
> (isDomain PI (PositiveInteger))
> - (isDOmain RN (Fraction (Integer)))
> + (isDomain RN (Fraction (Integer)))
> (isDomain SY (Symbol)))
> (text . "\newline ")
> (text . "\menuitemstyle{}\tab{2}")
> diff --git a/src/interp/compiler.boot b/src/interp/compiler.boot
> index 93ec12d4..5c7f0187 100644
> --- a/src/interp/compiler.boot
> +++ b/src/interp/compiler.boot
> @@ -1280,7 +1280,7 @@ constant_coerce([x, m, e], m') ==
> not(INTEGERP(x)) => nil
> -- Check if in range of FIXNUM on all supported implementations
> x > 8000000 or x < -8000000 => nil
> - m = $Integer or m = $PositiveInteger or $NonNegativeInteger =>
> + m = $Integer or m = $PositiveInteger or m = $NonNegativeInteger =>
> [x, m', e]
> nil
> m' = $DoubleFloat and m = $Float =>
> diff --git a/src/interp/g-cndata.boot b/src/interp/g-cndata.boot
> index 53c26817..86fb206e 100644
> --- a/src/interp/g-cndata.boot
> +++ b/src/interp/g-cndata.boot
> @@ -110,9 +110,6 @@ constructorAbbreviationErrorCheck(c,a,typ) ==
> throw_error_msg('precompilation, "S2IL0006", _
> '"Abbreviations must have 8 or fewer characters and should be uppercase.",
> [])
> - if s ~= UPCASE s then throw_msg("S2IL0006",
> - '"Abbreviations must have 8 or fewer characters and should be uppercase.",
> - [])
> abb := get_database(c, 'ABBREVIATION)
> name := get_database(a, 'CONSTRUCTOR)
> type := get_database(c, 'CONSTRUCTORKIND)
> diff --git a/src/interp/vmlisp.lisp b/src/interp/vmlisp.lisp
> index f51616bc..989b5c0d 100644
> --- a/src/interp/vmlisp.lisp
> +++ b/src/interp/vmlisp.lisp
> @@ -76,7 +76,7 @@
> (defun DOWNCASE (l)
> (cond ((stringp l) (string-downcase l))
> ((identp l) (intern (string-downcase (symbol-name l))))
> - ((characterp l) (char-downcase L))
> + ((characterp l) (char-downcase l))
> ((atom l) l)
> (t (mapcar #'downcase l))))
>
> diff --git a/src/lisp/num_gmp.lisp b/src/lisp/num_gmp.lisp
> index debcb796..df3f7c0d 100644
> --- a/src/lisp/num_gmp.lisp
> +++ b/src/lisp/num_gmp.lisp
> @@ -381,7 +381,7 @@
> (setf (symbol-function 'orig-multiply-bignums)
> (symbol-function 'ccl::multiply-bignums)))
>
> -(if (not (fboundp 'orig-bignum-gcd))
> +(if (not (fboundp 'orig-positive-bignum-gcd))
> (setf (symbol-function 'orig-positive-bignum-gcd)
> (symbol-function 'ccl::%positive-bignum-bignum-gcd)))
>


--
Waldek Hebisch

[Qian Yun]

On 4/22/26 8:34 AM, Waldek Hebisch wrote:
> On Wed, Apr 22, 2026 at 06:52:16AM +0800, Qian Yun wrote:
>> Some changes are close to typo fixes, some changes are obvious
>> and self-explanatory.
>>
>> - Qian
>>
>> (Disclaimer: this issue is found by LLM, but the analysis and patch
>> is thoroughly reviewed by me.)
>
> Concerning 'src/aldor/Makefile2.in' I do not know what the changed
> line is supposed to do, so no comment on this.
>
> The other ones are clearly good.
>

It overwrites this option "extra_ao_options=" for files in $(aldor_srcs)

Before the patch, because of the typo, the "extra_ao_options" is empty;
after correction, it is still empty, as expected.

- Qian

[Ralf Hemmecke]

On 4/22/26 02:34, Waldek Hebisch wrote:
>> diff --git a/src/aldor/Makefile2.in b/src/aldor/Makefile2.in
>> index 6403ba3d..8a70259d 100644
>> --- a/src/aldor/Makefile2.in
>> +++ b/src/aldor/Makefile2.in
>> @@ -48,7 +48,7 @@ al/libfricas.al: $(libfricas_members)
>> ar r $@ $+
>>
>> # From the .ap dependency we get a lot more dependencies, see cliques.mk.
>> -$(patsubst %,ao/%.ao,$(aldor_src)): extra_ao_options=
>> +$(patsubst %,ao/%.ao,$(aldor_srcs)): extra_ao_options=
>> $(patsubst %,ao/%.ao,$(FRICAS_CLIQUES)): extra_ao_options=-Wname=fricas -Mno-abbrev -Mpreview
>> .PRECIOUS: ao/%.ao
>> ao/%.ao: ap/%.ap

This one is OK. I just wanted to make sure that in contrast to the
FRICAS_CLIQUES files there are no additional options.

Ralf