remove!
4 views
Skip to first unread message
Ralf Hemmecke
Jan 21, 2019, 1:14:02 AM1/21/19
to fricas-devel
When I prepared the patch for remove!, I also stumpled over
http://fricas.github.io/api/KeyedDictionary.html#l-keyed-dictionary-remove
that, in particular, appears also in TableAggregate.
This function is destructive, but obviously not "over"-destructive,
because it modifies its second argument in a rather defined way.
I'm not particularly happy with that. Since there are other functions of
similar type like extract! and pop!, such functions cannot be easily
removed, but I propose to add a few words to the ++ docstring to
indicate that "defined behaviour".
If there is common agreement, I could try to prepare a patch for that.
(No need that this goes into the next release.)
Opinions.
Ralf
http://fricas.github.io/api/KeyedDictionary.html#l-keyed-dictionary-remove
that, in particular, appears also in TableAggregate.
This function is destructive, but obviously not "over"-destructive,
because it modifies its second argument in a rather defined way.
I'm not particularly happy with that. Since there are other functions of
similar type like extract! and pop!, such functions cannot be easily
removed, but I propose to add a few words to the ++ docstring to
indicate that "defined behaviour".
If there is common agreement, I could try to prepare a patch for that.
(No need that this goes into the next release.)
Opinions.
Ralf
Reply all
Reply to author
Forward
0 new messages