CI with Sage

9 views
Skip to first unread message

Martin R. Albrecht

unread,
Jun 27, 2020, 11:43:49 AM6/27/20
to Fplll-Devel, Matthias Koeppe
Hi all,

What’s your view on

https://github.com/fplll/fplll/pull/433

I’m personally inclined not to merge this one because

- The long testing time
- The dependency on a “private” repo: “mkoeppe/sage”
- I’m not sure FPLLL’s CI should depend on Sage
- If things break we don’t necessarily have access to machines/expertise to fix things (on Cygwin or ARM)

Thoughts?

I’ve CCed Matthias who sent the PR.

Cheers,
Martin

--

_pgp: https://keybase.io/martinralbrecht
_www: https://malb.io

Martin R. Albrecht

unread,
Jul 2, 2020, 5:32:18 AM7/2/20
to Fplll-Devel, Matthias Koeppe
Hi all,

Okay, that takes care of one of my reservations. The long waiting time is still an issue of concern for me. One thing that would be great, though, would be to push it manually pre-release. I guess that’s kind of achieved by triggering only on tags.

Another point to consider: if we’re using GH Actions for this, should we switch over to those completely? To ease the (mental) maintenance burden?

Cheers,
Martin


Matthias Koeppe <mko...@math.ucdavis.edu> writes:
> Just a quick comment below.
>
> On Sat, Jun 27, 2020 at 8:43 AM Martin R. Albrecht
> <martinr...@googlemail.com> wrote:
>> I’m personally inclined not to merge this one because
>> [...]
>> - The dependency on a “private” repo: “mkoeppe/sage”
>
> This will revert to repo sagemath/sage as soon as
> https://trac.sagemath.org/ticket/29091 is merged into the next Sage
> beta. (This is waiting for an fplll release.)
>
> Matthias
Reply all
Reply to author
Forward
0 new messages