Some comments on ecstatic earthworm

17 views
Skip to first unread message

JuanManuel Gimeno Illa

unread,
Sep 4, 2012, 12:48:32 PM9/4/12
to fp...@googlegroups.com
Hi Brian, 

     this book is awesome !!! 

    Some errors and suggestions from the new chapters (I haven't finished all the new parts yet but I don't know when I will be able to continue reading):

9.1 The restructureCourses should return PersistentVector not PersistentHashMap (and create one in the return). Would it work if defined as returning a Sequential? (If it would, the same could be done with the return type of restructureSignups)

11.2 I thing it would be more clear to write the initial expression with -> than to write it using nested expressions and use -> when applying CPS.

11.10 In the defenestrations-of example, a b gets converted into an 8 when using the error-monad.

     Sincerely,

     Juan Manuel





Brian Marick

unread,
Sep 13, 2012, 3:19:53 PM9/13/12
to fp...@googlegroups.com

On Sep 4, 2012, at 11:48 AM, JuanManuel Gimeno Illa wrote:
> 9.1 The restructureCourses should return PersistentVector not PersistentHashMap (and create one in the return). Would it work if defined as returning a Sequential? (If it would, the same could be done with the return type of restructureSignups)

Duh! Fixed. Returning a Sequential will work, so I've done that.

>
> 11.2 I thing it would be more clear to write the initial expression with -> than to write it using nested expressions and use -> when applying CPS.

I tried that, but I don't think it worked, so I reverted.

>
> 11.10 In the defenestrations-of example, a b gets converted into an 8 when using the error-monad.

Fixed.


-----
Brian Marick, Artisanal Labrador
Contract programming in Ruby and Clojure
Occasional consulting on Agile
Writing /Functional Programming for the Object-Oriented Programmer/: https://leanpub.com/fp-oo


Reply all
Reply to author
Forward
0 new messages