On Jul 16, 2020, at 8:57 PM, KoenP <koen....@gmail.com> wrote:
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/8c8f3474-ac7c-47b6-b509-cf0d78d88fb1o%40googlegroups.com.
<error_in_Gofish5.txt>
Ignore the error.
Then sort on different columns until the error disappears.Sent from my iPhoneOn Jul 16, 2020, at 8:57 PM, KoenP <koen....@gmail.com> wrote:
--Hi,I am facing an error in my GoFish5: Message: SQL: ORDER BY clause is invalid.Trust the attached file gives an enough information how to settle this.Anyone with a solution for this?Thanks,Koen
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
Thar method is in the file "GoFish_Results.scx"
PROCEDURE FillSearchResultsCursor
Local lcCollate, lcField, lcOrderBy, lcSearchEngineResultsAlias, lcSearchResultsAlias
Local lcSecondarySortField, lcSecondarySortOrder, lcSortField, lcSortOrder, lcTertiarySortField
Local lcTertiarySortOrder, lnSelect, loColumn
lcSearchEngineResultsAlias = Thisform.oSearchEngine.cSearchResultsAlias
lcSearchResultsAlias = Thisform.cSearchResultsAlias
lnSelect = Select()
lcOrderBy = ''
*** JRN 11/06/2015 : using !Empty(Field( to provide for case of changed field names in GF 5
*-- Construct Order By clause for Select statement from stored form property
If !Empty(Thisform.cSortField) and !Empty(Field(Thisform.cSortField, lcSearchEngineResultsAlias))
lcSortField = Thisform.cSortField
lcSortOrder = Thisform.cSortOrder
If (Empty(lcSortOrder) or ('ASC' $ Upper(lcSortOrder)))
lcSortOrder = 'ASC'
Endif
lcOrderBy = lcSortField + ' ' + lcSortOrder
Endif
If !Empty(Thisform.cSortFieldSecondary) and !Empty(Field(Thisform.cSortFieldSecondary, lcSearchEngineResultsAlias))
lcSecondarySortField = Thisform.cSortFieldSecondary
lcSecondarySortOrder = Thisform.cSortOrderSecondary
If (Empty(lcSecondarySortOrder) or ('ASC' $ Upper(lcSecondarySortOrder)))
lcSecondarySortOrder = 'ASC'
EndIf
lcOrderBy = lcOrderBy + ', ' + lcSecondarySortField + ' ' + lcSecondarySortOrder
Endif
If !Empty(Thisform.cSortFieldTertiary) and !Empty(Field(Thisform.cSortFieldTertiary, lcSearchEngineResultsAlias))
lcTertiarySortField = Thisform.cSortFieldTertiary
lcTertiarySortOrder = Thisform.cSortOrderTertiary
If (Empty(lcTertiarySortOrder) or ('ASC' $ Upper(lcTertiarySortOrder)))
lcTertiarySortOrder = 'ASC'
EndIf
lcOrderBy = lcOrderBy + ', ' + lcTertiarySortField + ' ' + lcTertiarySortOrder
Endif
If Empty(lcOrderBy)
lcOrderBy = 'filename, class, name, methodname'
thisform.cSortField = GetWordNum(lcOrderBy, 1, ',')
Else
lcOrderBy = Alltrim(lcOrderBy, 1, ',')
EndIf
Thisform.cOrderBy = lcOrderBy
*-- Make header bold for primary sort column
If Thisform.lInit
For each loColumn in Thisform.oGrid.Columns
loColumn.header1.FontBold = .f.
lcField = GetWordNum(loColumn.ControlSource, 2, '.')
If Upper(lcField) = Upper(GetWordNum(lcOrderBy, 1, ', '))
loColumn.header1.FontBold = .t.
Endif
Endfor
EndIf
*-- This gives us case insensitive sorting...
lcCollate = Set('Collate')
Try
Set Collate To 'General'
Catch to loException
EndTry
lcOrderBy = lcOrderBy + ', filename, class, name, methodname, MatchStart'
*-- Create the local cursor if it does not already exist -----------------------
If !Used(lcSearchResultsAlias)
Select * From (Select * From (lcSearchEngineResultsAlias) Order By &lcOrderBy) source;
Into Cursor (lcSearchResultsAlias) ReadWrite
Else && Otherwise, Zap it and rebuild from GFSE cursor...
Thisform.ClearSearchResultsCursor() && Zap it
*-- Build a temp local cursor in correct initial order
*TODO: The orderby clause here could fail since some field names were changed
* in relase 4.3.015. Need to handle this...
Select * From (Select * From (lcSearchEngineResultsAlias) Order By &lcOrderBy) source ;
Into Cursor gf_temp_csr ReadWrite
*-- Update local cursor in order that user has applied
*!* ******************** Removed 11/09/2015 *****************
*!* Insert Into (lcSearchResultsAlias) Select * From gf_temp_csr
Select (lcSearchResultsAlias)
Append from (Dbf('gf_temp_csr'))
Endif
Set Collate To (lcCollate)
Select (lcSearchResultsAlias)
Goto Top
Select (lnSelect)
ENDPROC
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/aefe6963-f252-4a5e-b363-5c244bd062c7o%40googlegroups.com.
On Jul 17, 2020, at 4:28 AM, Matt Slay <matt...@jordanmachine.com> wrote:
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/6a210511-86e2-1578-7912-f740fa9ad483%40jordanmachine.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/9940B30D-1BEE-4858-ADD1-DACF9185C671%40gmail.com.
Alternatively, I would think that when the error occurs he could suspend, setlcOrderby = ‘Name’And resume ...That would get him past the first bug, and then he could start sorting on any of the visible columns and repeat the whole process until the problem goes away.
On Jul 17, 2020, at 5:55 AM, Koen Piller <koen....@gmail.com> wrote:
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CACUu1Ss%2BhPzzvdUsyLQ85Z52p%3DtSZR6zOfpaJUXmfgE18ohLDA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/2F80BCAC-C2A0-4A0E-B918-E6EACBD6F0A7%40gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CACUu1Ss7C01_VoDchfMxtcRCfnKi_WiEkF4O2NynLPfbaM9stA%40mail.gmail.com.
On Jul 17, 2020, at 6:59 AM, KoenP <koen....@gmail.com> wrote:
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/28968df6-e5e2-493c-b806-94ed5ba4cf89o%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/4A07EA42-C0C2-4861-8A39-6FFDA2D84FC0%40gmail.com.
After you resume you need to sort on one of the columns.The error will likely recur.Then sort on a different column.
Repeat until there is no error.Sent from my iPhoneOn Jul 17, 2020, at 6:59 AM, KoenP <koen....@gmail.com> wrote:
--Jim,your suggestion to replace with Name works fine, thanks. But how to correct definitely, I cannot go on each and every time to replace and working with the debugger.Stay healthy,Koen
Op vrijdag 17 juli 2020 05:57:45 UTC+2 schreef KoenP:Hi,I am facing an error in my GoFish5: Message: SQL: ORDER BY clause is invalid.Trust the attached file gives an enough information how to settle this.Anyone with a solution for this?Thanks,Koen
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/3b359e87-cfde-46d2-aa89-0c13e30b5d6do%40googlegroups.com.
Is this not the same error I fixed some months ago? Hasn't it been added to the main code?
On Fri, Jul 17, 2020 at 11:07 AM Jim Nelson <jimrn...@gmail.com> wrote:
After you resume you need to sort on one of the columns.The error will likely recur.Then sort on a different column.
Repeat until there is no error.Sent from my iPhoneOn Jul 17, 2020, at 6:59 AM, KoenP <koen....@gmail.com> wrote:
--Jim,your suggestion to replace with Name works fine, thanks. But how to correct definitely, I cannot go on each and every time to replace and working with the debugger.Stay healthy,Koen
Op vrijdag 17 juli 2020 05:57:45 UTC+2 schreef KoenP:Hi,I am facing an error in my GoFish5: Message: SQL: ORDER BY clause is invalid.Trust the attached file gives an enough information how to settle this.Anyone with a solution for this?Thanks,Koen
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/28968df6-e5e2-493c-b806-94ed5ba4cf89o%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
Mike - Indeed, this was recorded on June 21, 2018 as Issue # 5 on the GoFish Repository on GitHub, however, that code change has not been added to the main code base, nor has an updated release of GF been released with this change in it.
https://github.com/mattslay/GoFish/issues/5
Maybe one day I will get around to this, but it is not something I can spend any time on at the moment.
However, give that GF is an open source project, anyone out there could apply the fix and send a pull request, that might expedite things. It need not wait around on me, or Jim to make a fix. We'd love to see others in the community dive in and be involved in GF code base and release cycles. It could help keep it alive in a more community-driven way.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CADNLL6cTOphnwCfnzUhMq8j6%3DzzdFNCBy40nxGchWgEbLm4udg%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/3b359e87-cfde-46d2-aa89-0c13e30b5d6do%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/e12b56b6-5ba6-4d43-95b1-857edbc8a871o%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/28968df6-e5e2-493c-b806-94ed5ba4cf89o%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/4A07EA42-C0C2-4861-8A39-6FFDA2D84FC0%40gmail.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/3e8f2abc-2829-7cea-eea6-941e7e1a32bf%40jordanmachine.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CADNLL6cAEsL4RoQi2nPN3BmS6Vu8PLmSw8N6D5mYNm%2B%3D0kpAfg%40mail.gmail.com.
Okay, so here are the steps (for anyone who wants to help with GF code base in the future)
1. Fork the GoFish repo into your own GitHub account.
2. Clone the code base to your own machine.
3. Make the code the code changes.
4. Commit locally
5. Push to your remote repo.
6. Send a Pull Request to the main GF repo that you Forked in Step 1.
7. I will accept your Pull Request, and do (some) local testing.
8. If my testing passes, I will build and release a new update though the Thor release tunnel.
Of all these steps, step # 8 is the most mysterious process, and a little harder to introduce other people to. But, unless we do get more people into that final step, updating through Thor can't happen, although, users could still manually update directly from the Repo files.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CADNLL6cAEsL4RoQi2nPN3BmS6Vu8PLmSw8N6D5mYNm%2B%3D0kpAfg%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/28968df6-e5e2-493c-b806-94ed5ba4cf89o%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/4A07EA42-C0C2-4861-8A39-6FFDA2D84FC0%40gmail.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CADNLL6cTOphnwCfnzUhMq8j6%3DzzdFNCBy40nxGchWgEbLm4udg%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/3e8f2abc-2829-7cea-eea6-941e7e1a32bf%40jordanmachine.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/5ab14f6b-e10c-4833-9c65-4ae8d046ff6do%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/5ab14f6b-e10c-4833-9c65-4ae8d046ff6do%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to foxprogofish...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/5ab14f6b-e10c-4833-9c65-4ae8d046ff6do%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CADNLL6exssRMAhvvryQqMvg1ufA69%3D%2BwikzYMwzPKg%3DKAAC06Q%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/B2D31387-FF12-4CF1-ADFB-72A916BD7256%40jordanmachine.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/5ab14f6b-e10c-4833-9c65-4ae8d046ff6do%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "GoFish" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foxpro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/foxprogofish/CADNLL6exssRMAhvvryQqMvg1ufA69%3D%2BwikzYMwzPKg%3DKAAC06Q%40mail.gmail.com.