[markww-foursquared] 2 new revisions pushed by markww on 2010-10-01 17:41 GMT

[markww-fo...@googlecode.com]

2 new revisions:

Revision: 53d7c9336a
Author: mar...@gmail.com
Date: Fri Oct 1 09:56:39 2010
Log: Fixed up friend invites from address book parser - I truly clobbered
t...
http://code.google.com/r/markww-foursquared/source/detail?r=53d7c9336a

Revision: c092ba27ed
Author: mar...@gmail.com
Date: Fri Oct 1 10:41:01 2010
Log: Burying parse error when submitting flagged venue info. The api
isn't ...
http://code.google.com/r/markww-foursquared/source/detail?r=c092ba27ed

==============================================================================
Revision: 53d7c9336a
Author: mar...@gmail.com
Date: Fri Oct 1 09:56:39 2010
Log: Fixed up friend invites from address book parser - I truly clobbered
this one in the switch from xml to json.
http://code.google.com/r/markww-foursquared/source/detail?r=53d7c9336a

Modified:

/main/src/com/joelapenna/foursquare/parsers/json/FriendInvitesResultParser.java

=======================================
---
/main/src/com/joelapenna/foursquare/parsers/json/FriendInvitesResultParser.java
Mon Sep 27 12:49:27 2010
+++
/main/src/com/joelapenna/foursquare/parsers/json/FriendInvitesResultParser.java
Fri Oct 1 09:56:39 2010
@@ -29,9 +29,14 @@
}
if (json.has("emails")) {
Emails emails = new Emails();
- JSONArray array = json.getJSONArray("emails");
- for (int i = 0; i < array.length(); i++) {
- emails.add(emails.get(i));
+ if (json.optJSONObject("emails") != null) {
+ JSONObject emailsAsObject = json.getJSONObject("emails");
+ emails.add(emailsAsObject.getString("email"));
+ } else if (json.optJSONArray("emails") != null) {
+ JSONArray emailsAsArray = json.getJSONArray("emails");
+ for (int i = 0; i < emailsAsArray.length(); i++) {
+ emails.add(emailsAsArray.getString(i));
+ }
}
obj.setContactEmailsOnNotOnFoursquare(emails);
}
@@ -39,7 +44,7 @@
Emails emails = new Emails();
JSONArray array = json.getJSONArray("invited");
for (int i = 0; i < array.length(); i++) {
- emails.add(emails.get(i));
+ emails.add(array.getString(i));
}
obj.setContactEmailsOnNotOnFoursquareAlreadyInvited(emails);
}

==============================================================================
Revision: c092ba27ed
Author: mar...@gmail.com
Date: Fri Oct 1 10:41:01 2010
Log: Burying parse error when submitting flagged venue info. The api isn't
returning a real response object, so parsing will fail. Not going to add a
special parse case. Should be fixed in API v2.
http://code.google.com/r/markww-foursquared/source/detail?r=c092ba27ed

Modified:
/main/src/com/joelapenna/foursquared/EditVenueOptionsActivity.java

=======================================
--- /main/src/com/joelapenna/foursquared/EditVenueOptionsActivity.java Fri
Aug 6 17:27:23 2010
+++ /main/src/com/joelapenna/foursquared/EditVenueOptionsActivity.java Fri
Oct 1 10:41:01 2010
@@ -7,7 +7,6 @@
import com.joelapenna.foursquare.Foursquare;
import com.joelapenna.foursquare.types.Response;
import com.joelapenna.foursquare.types.Venue;
-import com.joelapenna.foursquared.util.NotificationsUtil;

import android.app.Activity;
import android.app.ProgressDialog;
@@ -20,8 +19,8 @@
import android.text.TextUtils;
import android.util.Log;
import android.view.View;
-import android.view.Window;
import android.view.View.OnClickListener;
+import android.view.Window;
import android.widget.Button;
import android.widget.Toast;

@@ -165,7 +164,7 @@
private void startProgressBar() {
if (mDlgProgress == null) {
mDlgProgress = ProgressDialog.show(this,
-
getResources().getString(R.string.edit_venue_options_progress_title),
+ null,

getResources().getString(R.string.edit_venue_options_progress_message));
}
mDlgProgress.show();
@@ -191,7 +190,15 @@
Toast.LENGTH_SHORT).show();
}
} else {
- NotificationsUtil.ToastReasonForFailure(this, ex);
+ // The API is returning an incorrect response object here, it
should look like:
+ // { response: { "response": "ok" }}
+ // Instead it's just returning:
+ // { "response": "ok" }
+ // So the parser framework will fail on it. This should be
fixed with api v2,
+ // just going to assume success here.
+ //NotificationsUtil.ToastReasonForFailure(this, ex);
+ Toast.makeText(this,
getResources().getString(R.string.edit_venue_options_thankyou),
+ Toast.LENGTH_SHORT).show();
}
}