[fonttools/fonttools] 158dc7: [otlLib] Minor rewrite two lines

0 views
Skip to first unread message

Behdad Esfahbod

unread,
Aug 17, 2022, 5:03:46 PM8/17/22
to fontto...@googlegroups.com
Branch: refs/heads/otlLib-getEffectiveFormat
Home: https://github.com/fonttools/fonttools
Commit: 158dc7dee7f226f697b049fdc69b875d84cf9e42
https://github.com/fonttools/fonttools/commit/158dc7dee7f226f697b049fdc69b875d84cf9e42
Author: Behdad Esfahbod <beh...@behdad.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Lib/fontTools/otlLib/builder.py

Log Message:
-----------
[otlLib] Minor rewrite two lines


Commit: 2e62595219a486e73dc8c60c8f9692fb2c03007e
https://github.com/fonttools/fonttools/commit/2e62595219a486e73dc8c60c8f9692fb2c03007e
Author: Behdad Esfahbod <beh...@behdad.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Lib/fontTools/otlLib/builder.py

Log Message:
-----------
[otlLib] Use Value.getEffectiveFormat() instead of .getFormat()

This changes some test expectations. They are mostly desired. But
I don't see why we are creating empty lookups in the failing test
Tests/feaLib/data/ZeroValue_PairPos_vertical.ttx, instead of no
lookup at all. So that needs figuring out to complete this change
and then update expectation.


Commit: 4e4500cc95b2b0ded15f3b6b7b148dfb2865ca7f
https://github.com/fonttools/fonttools/commit/4e4500cc95b2b0ded15f3b6b7b148dfb2865ca7f
Author: Behdad Esfahbod <beh...@behdad.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Tests/feaLib/data/bug633.ttx
M Tests/varLib/data/test_results/test_vpal.ttx

Log Message:
-----------
[Tests] Fix expectation for recent changes to otlLib Value pruning


Compare: https://github.com/fonttools/fonttools/compare/e29caafc0c99...4e4500cc95b2
Reply all
Reply to author
Forward
0 new messages