[fonttools/fonttools] cd7e6e: Add type hints to feaLib.ast

0 views
Skip to first unread message

Simon Cozens

unread,
Aug 18, 2022, 10:21:46 AM8/18/22
to fontto...@googlegroups.com
Branch: refs/heads/fealib-typing
Home: https://github.com/fonttools/fonttools
Commit: cd7e6ef7f1de9e8fd52403a595720ae29fa99f2b
https://github.com/fonttools/fonttools/commit/cd7e6ef7f1de9e8fd52403a595720ae29fa99f2b
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/ast.py

Log Message:
-----------
Add type hints to feaLib.ast


Commit: 5774b024631dac88ea2d91d08058f07107b6ff90
https://github.com/fonttools/fonttools/commit/5774b024631dac88ea2d91d08058f07107b6ff90
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/variableScalar.py

Log Message:
-----------
Type-checking varLib currently involves a lot of false positives, so disable


Commit: 2c719ea423c3d950aba62eed13438a2f87b36e7a
https://github.com/fonttools/fonttools/commit/2c719ea423c3d950aba62eed13438a2f87b36e7a
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Tests/feaLib/parser_test.py

Log Message:
-----------
We changed empty-lookup-list behaviour, fix expectation


Commit: 94dee44260978c516f38481150cf7c61b6e19444
https://github.com/fonttools/fonttools/commit/94dee44260978c516f38481150cf7c61b6e19444
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Tests/feaLib/parser_test.py

Log Message:
-----------
Bug found when parse_anchor returns None


Commit: 5ce1497d0f413edfadf7f47beac3b351dc6b9cf4
https://github.com/fonttools/fonttools/commit/5ce1497d0f413edfadf7f47beac3b351dc6b9cf4
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-17 (Wed, 17 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/ast.py
M Lib/fontTools/feaLib/builder.py
M Lib/fontTools/feaLib/parser.py
M Tests/feaLib/parser_test.py

Log Message:
-----------
Create a Null Anchor object to avoid putting Nones into the AST.


Commit: ad2ba43e675f9a634d45ebf1a668dfbc016d55a0
https://github.com/fonttools/fonttools/commit/ad2ba43e675f9a634d45ebf1a668dfbc016d55a0
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-18 (Thu, 18 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/ast.py

Log Message:
-----------
Typing fixes found while typing the parser


Commit: 757cdf059102fae979539af6cc4e0dfd1ea48450
https://github.com/fonttools/fonttools/commit/757cdf059102fae979539af6cc4e0dfd1ea48450
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-18 (Thu, 18 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/ast.py

Log Message:
-----------
Avoid use of asFea, assume everything is a node


Commit: 1e2f45bb0720e1ed62c142d7f007e8d6a874bd34
https://github.com/fonttools/fonttools/commit/1e2f45bb0720e1ed62c142d7f007e8d6a874bd34
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-18 (Thu, 18 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/parser.py

Log Message:
-----------
Add typings to parser


Commit: 6b069df3466975072c84d115deb8ae8be792b8bd
https://github.com/fonttools/fonttools/commit/6b069df3466975072c84d115deb8ae8be792b8bd
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-18 (Thu, 18 Aug 2022)

Changed paths:
M Tests/feaLib/parser_test.py

Log Message:
-----------
Now everything in the AST is a node


Commit: 983a7c45f78c53add96767a43ab30256cd666cd1
https://github.com/fonttools/fonttools/commit/983a7c45f78c53add96767a43ab30256cd666cd1
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-18 (Thu, 18 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/builder.py

Log Message:
-----------
Typings for the builder


Commit: 5d2fee0e5e7af2c55607a8193274ab33d04d5566
https://github.com/fonttools/fonttools/commit/5d2fee0e5e7af2c55607a8193274ab33d04d5566
Author: Simon Cozens <si...@simon-cozens.org>
Date: 2022-08-18 (Thu, 18 Aug 2022)

Changed paths:
M Lib/fontTools/feaLib/ast.py

Log Message:
-----------
I think this is actually the fix for #2747


Compare: https://github.com/fonttools/fonttools/compare/cd7e6ef7f1de%5E...5d2fee0e5e7a
Reply all
Reply to author
Forward
0 new messages