[fonttools/fonttools] f91697: [instancer] Fix output filename decision-making

0 views
Skip to first unread message

Behdad Esfahbod

unread,
May 30, 2024, 1:49:29 PMMay 30
to fontto...@googlegroups.com
Branch: refs/heads/instancer-name
Home: https://github.com/fonttools/fonttools
Commit: f9169719134a6c6016fcd6bcf98b2c123fca021f
https://github.com/fonttools/fonttools/commit/f9169719134a6c6016fcd6bcf98b2c123fca021f
Author: Behdad Esfahbod <beh...@behdad.org>
Date: 2024-05-30 (Thu, 30 May 2024)

Changed paths:
M Lib/fontTools/varLib/instancer/__init__.py

Log Message:
-----------
[instancer] Fix output filename decision-making

All limits are tuples now when not None. The old logic was
broken and for the following command:

$ fonttools varLib.instancer AdobeVFPrototype.otf CNTR=50:80 wght=900

it was saving the output with the name suffix `-instance`, whereas
it's clearly a partial instantiation. This fixes that.



To unsubscribe from these emails, change your notification settings at https://github.com/fonttools/fonttools/settings/notifications

Cosimo Lupo

unread,
May 31, 2024, 9:22:20 AMMay 31
to fontto...@googlegroups.com
Branch: refs/heads/main
Home: https://github.com/fonttools/fonttools
Commit: f9169719134a6c6016fcd6bcf98b2c123fca021f
https://github.com/fonttools/fonttools/commit/f9169719134a6c6016fcd6bcf98b2c123fca021f
Author: Behdad Esfahbod <beh...@behdad.org>
Date: 2024-05-30 (Thu, 30 May 2024)

Changed paths:
M Lib/fontTools/varLib/instancer/__init__.py

Log Message:
-----------
[instancer] Fix output filename decision-making

All limits are tuples now when not None. The old logic was
broken and for the following command:

$ fonttools varLib.instancer AdobeVFPrototype.otf CNTR=50:80 wght=900

it was saving the output with the name suffix `-instance`, whereas
it's clearly a partial instantiation. This fixes that.


Commit: c61fae7a7dca979fcbab35768a16f6880fa19a38
https://github.com/fonttools/fonttools/commit/c61fae7a7dca979fcbab35768a16f6880fa19a38
Author: Cosimo Lupo <cos...@anthrotype.com>
Date: 2024-05-31 (Fri, 31 May 2024)

Changed paths:
M Lib/fontTools/varLib/instancer/__init__.py

Log Message:
-----------
Merge pull request #3548 from fonttools/instancer-name

[instancer] Fix output filename decision-making


Compare: https://github.com/fonttools/fonttools/compare/f4669f0538a3...c61fae7a7dca
Reply all
Reply to author
Forward
0 new messages