[fonttools/fonttools] fb5145: [diff] Use nargs="+" for -t/-x and fix empty list ...

0 views
Skip to first unread message

Cosimo Lupo

unread,
Mar 6, 2026, 6:57:16 AM (5 days ago) Mar 6
to fontto...@googlegroups.com
Branch: refs/heads/fix-4025-ttx-empty-tables
Home: https://github.com/fonttools/fonttools
Commit: fb51455df3c6411b0fce35319a5b23ccfba21eb9
https://github.com/fonttools/fonttools/commit/fb51455df3c6411b0fce35319a5b23ccfba21eb9
Author: Cosimo Lupo <cl...@google.com>
Date: 2026-03-06 (Fri, 06 Mar 2026)

Changed paths:
M Lib/fontTools/diff/__init__.py
M Tests/ttLib/ttFont_test.py

Log Message:
-----------
[diff] Use nargs="+" for -t/-x and fix empty list filtering (#4025)

- Change argparse nargs from "*" to "+" for --include/-t and --exclude/-x
so that passing the flag with no table names is rejected at the CLI level.

- Use truthiness checks instead of `is not None` in _iter_filtered_table_tags
so that [] and None are treated the same (both mean "no filtering").
This avoids the same [] vs None ambiguity that caused the ttx regression
in #4025.

- Add regression tests for saveXML table/skipTables filtering.


Commit: 3f2ff510d55570253b1ac895ed3ebeec6717a212
https://github.com/fonttools/fonttools/commit/3f2ff510d55570253b1ac895ed3ebeec6717a212
Author: Cosimo Lupo <cl...@google.com>
Date: 2026-03-06 (Fri, 06 Mar 2026)

Changed paths:
M Lib/fontTools/ttLib/ttFont.py

Log Message:
-----------
[ttLib] Clarify saveXML docstring: falsy tables means dump all (#4025)

Make explicit that both None and [] are treated as "dump all tables",
which is the longstanding behavior.


Compare: https://github.com/fonttools/fonttools/compare/fb51455df3c6%5E...3f2ff510d555

To unsubscribe from these emails, change your notification settings at https://github.com/fonttools/fonttools/settings/notifications

Cosimo Lupo

unread,
Mar 6, 2026, 7:06:55 AM (5 days ago) Mar 6
to fontto...@googlegroups.com
Branch: refs/heads/main
Commit: e10c60054b0427180d85f85d5b1fcd08979706a2
https://github.com/fonttools/fonttools/commit/e10c60054b0427180d85f85d5b1fcd08979706a2
Author: Cosimo Lupo <cos...@anthrotype.com>
Date: 2026-03-06 (Fri, 06 Mar 2026)

Changed paths:
M Lib/fontTools/diff/__init__.py
M Lib/fontTools/ttLib/ttFont.py
M Tests/ttLib/ttFont_test.py

Log Message:
-----------
Merge pull request #4056 from fonttools/fix-4025-ttx-empty-tables

Add saveXML regression tests and fix diff table filtering


Compare: https://github.com/fonttools/fonttools/compare/d0d007bea8b5...e10c60054b04
Reply all
Reply to author
Forward
0 new messages