[fonttools/fonttools] 74fc26: [feaLib] Raise an error for rsub with NULL target

0 views
Skip to first unread message

Khaled Hosny

unread,
Nov 4, 2025, 10:37:23 AM11/4/25
to fontto...@googlegroups.com
Branch: refs/heads/issue-2952
Home: https://github.com/fonttools/fonttools
Commit: 74fc26a5efed007ea3c245e92299f477ff7523ae
https://github.com/fonttools/fonttools/commit/74fc26a5efed007ea3c245e92299f477ff7523ae
Author: Khaled Hosny <kha...@aliftype.com>
Date: 2025-11-04 (Tue, 04 Nov 2025)

Changed paths:
M Lib/fontTools/feaLib/parser.py
M Tests/feaLib/parser_test.py

Log Message:
-----------
[feaLib] Raise an error for rsub with NULL target

Glyph deletion can’t be supported with reverse chaining substitution and
we were silently converting it to chaining substitution.

See discussion in https://github.com/fonttools/fonttools/issues/2952.

Fixes https://github.com/fonttools/fonttools/issues/2952



To unsubscribe from these emails, change your notification settings at https://github.com/fonttools/fonttools/settings/notifications

Khaled Hosny

unread,
Nov 4, 2025, 1:28:52 PM11/4/25
to fontto...@googlegroups.com
Branch: refs/heads/main
Home: https://github.com/fonttools/fonttools
Commit: 74fc26a5efed007ea3c245e92299f477ff7523ae
https://github.com/fonttools/fonttools/commit/74fc26a5efed007ea3c245e92299f477ff7523ae
Author: Khaled Hosny <kha...@aliftype.com>
Date: 2025-11-04 (Tue, 04 Nov 2025)

Changed paths:
M Lib/fontTools/feaLib/parser.py
M Tests/feaLib/parser_test.py

Log Message:
-----------
[feaLib] Raise an error for rsub with NULL target

Glyph deletion can’t be supported with reverse chaining substitution and
we were silently converting it to chaining substitution.

See discussion in https://github.com/fonttools/fonttools/issues/2952.

Fixes https://github.com/fonttools/fonttools/issues/2952


Commit: 8e5c52df1a87b6acadcab84e30e3951ac84c67a4
https://github.com/fonttools/fonttools/commit/8e5c52df1a87b6acadcab84e30e3951ac84c67a4
Author: Khaled Hosny <kha...@aliftype.com>
Date: 2025-11-04 (Tue, 04 Nov 2025)

Changed paths:
M Lib/fontTools/feaLib/parser.py
M Tests/feaLib/parser_test.py

Log Message:
-----------
Merge pull request #3979 from fonttools/issue-2952

[feaLib] Raise an error for rsub with NULL target


Compare: https://github.com/fonttools/fonttools/compare/121368896a04...8e5c52df1a87
Reply all
Reply to author
Forward
0 new messages