Bug in estimated_time - class.effort.php

[Mario Stiffel]

Hello,

I'v found the following bug in rc10:

flyspray-1.0-rc10

/includes/class.effort.php

Line 261: $minutes = floor(($seconds - ($hours * 3600)) / 60);

should be: $minutes = floor(($seconds - ($days * $factor) - ($hours * 3600)) / 60);

Can you add the patch in the next version?

Best regards,

  Mario Stiffel

[france...@gmail.com]

Hi Mario, would you mind opening an issue on the forum or, even better, submit your fix opening a pull request on GitHub so that you can better explain your reasoning behind it?

 

Regards,

Francesco

 

---

--
You received this message because you are subscribed to the Google Groups "flyspray" group.
To unsubscribe from this group and stop receiving emails from it, send an email to flyspray+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flyspray/b9eff9d4-0029-442b-bb81-13010b38c22cn%40googlegroups.com.

[peterdd]

It is fixed in master branch.