flying-saucer pull request

[Jens Rutschmann]

Hi Peter and Patrick,

I've just opened a new pull request (#38) to make the target-counter function consider page sequences.

Could you give it a short review? I'm not really sure what that 'initial' page number is used for. It seems to the
ItextRenderer always sets it to 0. Nevertheless I tried to incorporate it like the existing getRelativePageNo() method does.

Should I then merge the pull request myself or do you want to do it?

Cheers,
Jens

[Peter Brant]

Hi Jens,

Looks good to me.  Feel free to merge.

The initial page number can be set when calling writeNextDocument() (i.e. when rendering multiple documents to a single PDF).  We've used it for rendering huge reports in chunks with a 1 to n page numbering across all sections.

Do you want me to do an official release with this change?  (trivial to do)

Pete

--
You received this message because you are subscribed to the Google Groups "Flying Saucer Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to flying-saucer-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Jens Rutschmann]

Hi Pete,

I just merged the pull request. If you could do a release that would be great.

Thanks,
Jens

>> email to flying-saucer-dev+unsubscribe@**googlegroups.com<flying-saucer-dev%2Bunsu...@googlegroups.com>
>> .
>> For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
>> .
>>
>

[Peter Brant]

9.0.4 has been released to the Sonatype OSS repo.  It'll be on central in a couple of hours.

Pete

email to flying-saucer-dev+unsubscribe@**googlegroups.com<flying-saucer-dev%2Bunsubscribe@googlegroups.com>

.
For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
.

--
You received this message because you are subscribed to the Google Groups "Flying Saucer Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flying-saucer-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Jens Rutschmann]

That was fast. Thanks Pete !

>>>> email to flying-saucer-dev+unsubscribe@****googlegroups.com<flying-**
>>>> saucer-dev%2Bunsubscribe@**googlegroups.com<flying-saucer-dev%252Buns...@googlegroups.com>
>>>>>
>>>> .
>>>> For more options, visit https://groups.google.com/****groups/opt_out<https://groups.google.com/**groups/opt_out>
>>>> <https://groups.**google.com/groups/opt_out<https://groups.google.com/groups/opt_out>

>>>>>
>>>> .
>>>>
>>>>
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Flying Saucer Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an

>> email to flying-saucer-dev+unsubscribe@**googlegroups.com<flying-saucer-dev%2Bunsu...@googlegroups.com>