Pull request 44 for better controlling named destinations

[Jens Rutschmann]

Hi all,

I've just opened https://github.com/flyingsaucerproject/flyingsaucer/pull/44

Would be great if you could give it a short review (should be
uncomplicated).

Basically I've introduced a new CSS property that must be set on
elements in order to create a named destination with their ID attribute
value:

span.should-be-a-destination {
-fs-named-destination: create;
}

span.should-not-be-a-destination {
-fs-named-destination: none;
}

The current approach is to create a named destination for each element
that has an ID attribute.


Is it the correct way to do that via CSS or would a data attribute suit
better (harder to add to pre-created HTML though)?

Thanks,
Jens

[Peter Brant]

Looks good to me.  It might be a minor hack, but the CSS subsystem is definitely the most well developed way of passing values around in FS.   

Pete

--
You received this message because you are subscribed to the Google Groups "Flying Saucer Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to flying-saucer-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.