Flutter engine builds for Windows?

[Krzysztof Kowalczyk]

Looking at mac build https://github.com/google/flutter-desktop-embedding/blob/master/macos/library/update_engine.sh#L66:11 I can see that mac binaries for the underlying engine are pulled from https://storage.googleapis.com/flutter_infra/flutter/${FLUTTER_EMBEDDER_SHA}/darwin-x64/$FRAMEWORK_ARCHIVE_FILENAME

Does that exist for Windows builds as well? If yes, what is win equivalent of darwin-x64? Are there both 64-bit and 32-bit builds?

Looking at code for Mac wrapper, writing Windows wrapper shouldn't be hard as long as there are DLLs for Windows build of flutter engine.

-- kjk

[Chinmay Garde]

The buildbots do not upload a Windows Embedder API DLL. Users of the Embedder API will have to build the target specified on the Wiki page manually for now just like Linux.

Chinmay

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.
To post to this group, send email to flutter-deskto...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/8e3b3615-848a-4b2a-85db-9790d56fdc28%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[ds8...@gmail.com]

I've built the Flutter Engine DLL on Windows with a few hacks. Should I attempt to clean up my source and submit a PR?

On Tuesday, February 27, 2018 at 6:20:37 PM UTC-5, Chinmay Garde wrote:

The buildbots do not upload a Windows Embedder API DLL. Users of the Embedder API will have to build the target specified on the Wiki page manually for now just like Linux.

Chinmay

On Tue, Feb 27, 2018 at 2:16 PM Krzysztof Kowalczyk <kkowa...@gmail.com> wrote:

Looking at mac build https://github.com/google/flutter-desktop-embedding/blob/master/macos/library/update_engine.sh#L66:11 I can see that mac binaries for the underlying engine are pulled from https://storage.googleapis.com/flutter_infra/flutter/${FLUTTER_EMBEDDER_SHA}/darwin-x64/$FRAMEWORK_ARCHIVE_FILENAME

Does that exist for Windows builds as well? If yes, what is win equivalent of darwin-x64? Are there both 64-bit and 32-bit builds?

Looking at code for Mac wrapper, writing Windows wrapper shouldn't be hard as long as there are DLLs for Windows build of flutter engine.

-- kjk

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embedding-dev+unsub...@googlegroups.com.

[si...@devangels.london]

Would love to see the results of this. I can help with the Windows dev.

[Krzysztof Kowalczyk]

I don't speak for the project but I would love to see that happen.

Is your work on GitHub already so that we can take a peek?

-- kjk

[Chinmay Garde]

Patches would be great!

Chinmay

On Wed, Feb 28, 2018 at 11:00 AM Krzysztof Kowalczyk <kkowa...@gmail.com> wrote:

I don't speak for the project but I would love to see that happen.

Is your work on GitHub already so that we can take a peek?

-- kjk

On Wednesday, February 28, 2018 at 8:24:52 AM UTC-8, ds8...@gmail.com wrote:

I've built the Flutter Engine DLL on Windows with a few hacks. Should I attempt to clean up my source and submit a PR?

On Tuesday, February 27, 2018 at 6:20:37 PM UTC-5, Chinmay Garde wrote:

The buildbots do not upload a Windows Embedder API DLL. Users of the Embedder API will have to build the target specified on the Wiki page manually for now just like Linux.

Chinmay

On Tue, Feb 27, 2018 at 2:16 PM Krzysztof Kowalczyk <kkowa...@gmail.com> wrote:

Looking at mac build https://github.com/google/flutter-desktop-embedding/blob/master/macos/library/update_engine.sh#L66:11 I can see that mac binaries for the underlying engine are pulled from https://storage.googleapis.com/flutter_infra/flutter/${FLUTTER_EMBEDDER_SHA}/darwin-x64/$FRAMEWORK_ARCHIVE_FILENAME

Does that exist for Windows builds as well? If yes, what is win equivalent of darwin-x64? Are there both 64-bit and 32-bit builds?

Looking at code for Mac wrapper, writing Windows wrapper shouldn't be hard as long as there are DLLs for Windows build of flutter engine.

-- kjk

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/8e3b3615-848a-4b2a-85db-9790d56fdc28%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/70525e5c-d528-4e04-912c-9063a5b8cf0e%40googlegroups.com.

[Stuart Morgan]

We'd certainly like to have a Windows version in the repository, so that would be great!

Just to make sure the project boundaries are clear: if you have a GN build system for the engine DLL, that part should go to the Flutter project (assuming they are interested in adding that to their existing macOS and Linux builds). But a library implementing the embedding API and an example app using it are definitely welcome here.

-Stuart

To post to this group, send email to flutter-desktop-embedding-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/f81ccedf-bee0-4476-98c7-cfdc85214ffd%40googlegroups.com.

[clarke...@gmail.com]

In attempting to follow the build instructions for windows from here: 

https://github.com/flutter/engine/blob/master/CONTRIBUTING.md

Part way through the initial gclient sync, I'm being asked:

Username for 'https://chrome-internal.googlesource.com':

which isn't referred to in the instructions.  Is this expected?

[Stuart Morgan]

See this thread for the solution:

https://groups.google.com/d/msg/flutter-dev/IyXM4D7OKyg/uVLSD7tpBwAJ

There unfortunately appear to be two versions of the instructions, and one of them is missing this information.

-Stuart

On Mon, Jul 2, 2018 at 11:56 AM <clarke...@gmail.com> wrote:

In attempting to follow the build instructions for windows from here: 

https://github.com/flutter/engine/blob/master/CONTRIBUTING.md

Part way through the initial gclient sync, I'm being asked:

Username for 'https://chrome-internal.googlesource.com':

which isn't referred to in the instructions.  Is this expected?

On Wednesday, February 28, 2018 at 11:34:40 AM UTC-8, Stuart Morgan wrote:

We'd certainly like to have a Windows version in the repository, so that would be great!

Just to make sure the project boundaries are clear: if you have a GN build system for the engine DLL, that part should go to the Flutter project (assuming they are interested in adding that to their existing macOS and Linux builds). But a library implementing the embedding API and an example app using it are definitely welcome here.

-Stuart

On Wed, Feb 28, 2018 at 8:24 AM, <ds8...@gmail.com> wrote:

I've built the Flutter Engine DLL on Windows with a few hacks. Should I attempt to clean up my source and submit a PR?

On Tuesday, February 27, 2018 at 6:20:37 PM UTC-5, Chinmay Garde wrote:

The buildbots do not upload a Windows Embedder API DLL. Users of the Embedder API will have to build the target specified on the Wiki page manually for now just like Linux.

Chinmay

On Tue, Feb 27, 2018 at 2:16 PM Krzysztof Kowalczyk <kkowa...@gmail.com> wrote:

Looking at mac build https://github.com/google/flutter-desktop-embedding/blob/master/macos/library/update_engine.sh#L66:11 I can see that mac binaries for the underlying engine are pulled from https://storage.googleapis.com/flutter_infra/flutter/${FLUTTER_EMBEDDER_SHA}/darwin-x64/$FRAMEWORK_ARCHIVE_FILENAME

Does that exist for Windows builds as well? If yes, what is win equivalent of darwin-x64? Are there both 64-bit and 32-bit builds?

Looking at code for Mac wrapper, writing Windows wrapper shouldn't be hard as long as there are DLLs for Windows build of flutter engine.

-- kjk

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/8e3b3615-848a-4b2a-85db-9790d56fdc28%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/f81ccedf-bee0-4476-98c7-cfdc85214ffd%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/9325dc54-f4f5-4bb9-88ff-3f8558bf8ae6%40googlegroups.com.

[clarke...@gmail.com]

Awesome, thx Stuart, that's got me a lot further, I have a VS project and have successfully compiled 2671 out of 3557 files!  Should I post follow-on questions in the flutter dev group or is here OK?  Currently hitting a failure on file engine\src\third_party\skia\src\gpu\grprimitiveprocessor.h

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embedding-dev+unsub...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/8e3b3615-848a-4b2a-85db-9790d56fdc28%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embedding-dev+unsub...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/f81ccedf-bee0-4476-98c7-cfdc85214ffd%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embedding-dev+unsub...@googlegroups.com.

[Stuart Morgan]

You're probably better off posting to flutter-dev, since there are probably people there familiar with building the engine who aren't on this list. Feel free to cross-post here though so other people working on trying to get a Windows embedder up and running can easily follow along.

-Stuart

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/8e3b3615-848a-4b2a-85db-9790d56fdc28%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/f81ccedf-bee0-4476-98c7-cfdc85214ffd%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/9325dc54-f4f5-4bb9-88ff-3f8558bf8ae6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "Desktop Embedding for Flutter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flutter-desktop-embe...@googlegroups.com.

To post to this group, send email to flutter-deskto...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/46d9edf4-3bcc-4e45-a774-e37940dc6aab%40googlegroups.com.

[Ian Hickson]

Please file a bug for us to fix this documentation (or submit a PR to do it, if you prefer :-) ).

To view this discussion on the web visit https://groups.google.com/d/msgid/flutter-desktop-embedding-dev/CABEeGCe1TE5DPQ84Cg%3DECpcaRC08v6%2BGW%3DFLnC%2BBHTAX9E268w%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Ian Hickson

😸

[Stuart Morgan]

I think the real problem is that that version of the Chromium depot_tools docs is wrong, rather than the Flutter engine docs being wrong. I have a TODO to dig into it to figure out why there are two slightly different versions, I just haven't gotten to it yet.

-Stuart