Hi Albrecht,
On 10/16/26 3:27 PM, 'Albrecht
Schlosser' via fltk.general wrote:
Great, thanks for all your efforts.
I read the entire tutorial (V2) and found some bugs (mostly typos)
which I would like to report and/or fix. Unfortunately I couldn't
find the source(s) for the PDF file. Wouldn't it be great if
others could contribute to the source of the PDF tutorial by using
GitHub Issues and PR's?
Let me guess, most of the typos are language related. English is not
my native langues (nor is it for Georg).
And another major catagory of problems is the examples.
I have introduces code changes without fully understanding all of
the coding standard for FLTK.
While I did test all code and it compiles in GCC and MSVC I can not
test the coding standard.
Some of my changes may be short sighted (and mis some points,
introducing problems) or too strict than is absolutely required
(resulting in stiffer code than is needed).
Georg never made the original source for the PDF file available and
is quite fragile, document processor format, not plain text file(s).
Changing the original sources needs carefull attention to not
disturb the layout in the PDF file.
That is why I continue with the policy of Georg and do not provide
the original source file.
But there are alternatives.
It is possible to load the PDF file in LibreOffice or MS Office and
edit that. LibreOffice preserves the layout quite well, I have not
tested MS Office.
This option is suitable for correcting language typos. If you make
changes and send me the results I can diff it and introduce the
changes in the original sources.
For code changes you can change the example sources in the github
repository and report issues (with a diff) or make a pull request.
Again, I can take the changes and introduce it in the original
sources.
Of cause you can also point out the problem direct, as you did for
example1.
If not I
could "export" the text (pdftotext), edit the exported text, and
file a diff, but that would be more effort for both sides and less
reliable. What do you think?
The repository always contains the latest versions of all examples,
exported from the tutorial. The example code is kept in sync with
the tutorial PDF.
I included details on how it is done to show the process and then
found out that I will be almost the only person needing it. But your
welcome to work with it.
For now, here are some issues, some of which were already in the
old version (V1), but anyway:
All widget classes use the "Fl_" prefix with capital 'F' and
lowercase 'l'. While all the code is fine (otherwise it wouldn't
compile on Linux), there are classes mentioned in the text with
uppercase 'L' which is wrong.
The same is true for the static class "Fl".
OTOH constants etc. may use the "FL" prefix, but that's
intentional. I didn't notice any mistakes in such constants.
I have noticed some of the points but made no changes for it. The
code is compiling but is violating the FLTK coding standard.
Should I change it? (IMHO I think I should.) What is your advise?
Chapter 3. "Installation of the FLTK toolkit" - a.) Linux: "do
configure,make,install" : this is no longer possible since FLTK
1.5.0, there's only CMake available, which is fully supported and
recommended since 1.4.x (1.4.5 works fine).
Noticed that but I have not changed the text. It still works and the
aim was to change as little as possible in the text.
For building and testing against both versions of FLTK (v1.4 and
v1.5) I only use CMake.
I will put in a remark for it, better to let the tutorial text
reflect this.
Also, in text to/after example9.cpp: s/FL-Pixmap/Fl_Pixmap/
(only 1 occurrence).
Done. (only 1 occurrence).
There are other places that could be impoved, considering current
changes in FLTK, and some typos, but that would be suggestions for
an issue, PR, or GitHub Discussion if you decide to enable
"discussions".
I have opened the "discussions" tab.
Thanks again
Albrecht
Thanks for your support.
Andre.