Mar 3, 2023, 1:58:00 PMMar 3
I fixed (or tried to fix) a bunch of warnings compiling 1.3.8 forked from master on github and submitted a pull request.
There is one warning I can't really fix without some redesigning of the code.
In line 33 of fluid.cxx, undo_filename function, there is this snprintf call:
snprintf(buf, bufsize, "%sundo_%d_%d.fl", undo_path, getpid(), level);
where undo_path is of dimension FL_PATH_MAX and bufsize is an input to the function, that most if not all of the time, is also of dimension FL_PATH_MAX.
The "n" in snprintf should protect the printf from writing beyond the end of the array, but if the string in undo_path is of length FL_PATH_MAX (well, close to it), there is no space left in buf to append "undo_<pid>_<level>.fl" to it.
No idea what the code is doing, probably providing undoing capability to something, but it that (unlikely?) case it may not work as intended.