On 1/4/22 11:39 AM Manolo wrote:
> @Albrecht To continue the logic of the present RFC, I would suggest to
> move #include <FL/fl_config.h> from
> FL/platform.H to FL/platform_types.h.
> Since platform.H includes platform_types.h, nothing will break, and
> code using the Fl_Offscreen type
> defined in platform_types.h, will always see the correct,
> platform-dependent, definition of this type.
> If you agree, I can do this change,
Feel free to do this. I wouldn't mind if it was included in both files
because <FL/fl_config.h> has its own include guards anyway.
If you edit these two files (FL/platform_types.h and FL/platform.H)
please make sure that we *use* the new feature and replace '#else //
X11' with '#elif defined(FLTK_USE_X11)'. This would fix an omission of
I'm not sure if we should add another '#else' case though. In earlier
versions we had something like "#error unsupported platform" or similar
but I'd tend to leave this open without warning or error. Maybe an empty
'#else' clause just for documentation?
> after having clarified where exactly #include <FL/Fl_Export.H>
> should be positioned.
This is independent of the other stuff and can be before or after
<FL/fl_config.h> or whatever.