On 11/25/21 5:26 PM Manolo wrote:
> I propose the series of modifications given in the attached patch
> to fix for 1.4 issue #254: remove hardware overlay support.
> This would remove one milestone item for Release 1.4
> The proposal leaves unchanged the support of HAVE_GL_OVERLAY
> for the WIN32 platform.
> Can someone give info about whether this is functional?
> With Windows inside VirtualBox, there's no access to such feature.
I have no idea, but see Ian's post.
> Any comment?
I propose to proceed with the X11 overlay stuff independent of the
Windows HAVE_GL_OVERLAY question so we can close issue #254.
The Windows stuff should be separated anyway in another issue / patch / PR.
One minor nitpick regarding the patch: the alignment in line 635 of the
patch might need adjustment (not tested):
Line # ca. 233 of new src/drivers/Xlib/Fl_Xlib_Graphics_Driver_color.cxx:
- numcolors = fl_visual->colormap_size;
+ numcolors = fl_visual->colormap_size;
(or similar, edited manually)
Other than that: great, please go ahead. Thanks.